Page MenuHomePhabricator

Make bitcoin-seeder a first class citizen of ABC
ClosedPublic

Authored by deadalnix on Sep 26 2017, 16:47.

Details

Summary

Bitcoin seeder is a tool make by Pieter Wuille that is useful to create seeders. In order to reduce the maintenance burden, I wish to add it as a firstc lass citizen in ABC. This way, it'll be able to share code with ABC - which should provide good insight on what needs to be refactored and how - and can be distributed with it.

The seeder has been modified to use the Cash Magic when etablishing connexions and filter nodes based on NODE_BITCOIN_CASH rather than NODE_WITNESS which doesn't exist ont he Bitcoin Cash network. This work is based on the Bitcoin Cash seeder by @sickpig .

It comes with integration in the current build system.

Test Plan
make check

Ensure that the bitcoin-seeder executable is created properly. Run it and see it behaves as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
seeder
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 891
Build 891: arc lint + arc unit

Event Timeline

The build file changes look good. I did not review the source code due to be being a forklift. I can't build this right now, but I will check it later tonight.

wonder if you could have used git subtree rather than including the code directly in the ABC tree

This revision is now accepted and ready to land.Sep 28 2017, 09:05
This revision was automatically updated to reflect the committed changes.