- unsigned char => uint8_t
- C++ style imprts
- project import before library imports
- Relocate some comments for better layout
- Reorder inline and static qualifiers
- Remove blanket namespace imports
- Upgrade some of the loops for C++11 style loops
Details
Details
- Reviewers
sickpig schancel dagurval freetrader - Group Reviewers
Restricted Project - Commits
- rSTAGINGf7e57344aa19: Numerous improvement to the seeder's code
rABCf7e57344aa19: Numerous improvement to the seeder's code
Compile and run the seeder.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- seederimprove
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 901 Build 901: arc lint + arc unit
Event Timeline
| src/seeder/bitcoin.cpp | ||
|---|---|---|
| 26 | don't we usually got to a new line also if the then branch is a one-liner? | |
| src/seeder/main.cpp | ||
| 439 | don't recall BU having a cash seeder for the testnet | |
| src/seeder/netbase.cpp | ||
| 835 | why not uint something? | |
| src/seeder/serialize.h | ||
| 135 | unsigned int? | |
| src/seeder/bitcoin.cpp | ||
|---|---|---|
| 26 | We do whatever the formatter does. | |
| src/seeder/main.cpp | ||
| 439 | It's in ABC's source code. Someone must have given us this address. | |
| src/seeder/netbase.cpp | ||
| 835 | I don't know, it was an int and it is still an int :) | |
| src/seeder/serialize.h | ||
| 135 | We aren't sending message more than 4Gb anyway so it doesn't matter. Plus the whole serialization code is trashed in another diff. | |
| src/seeder/bitcoin.cpp | ||
|---|---|---|
| 26 | fair point. hope that clang-format does not develop an evil form of AI otherwise... 😄 | |
| src/seeder/main.cpp | ||
| 439 | copying something wrong doesn't making correct magically just checked there's no testnet-seed.bitcoinunlimited.info. if it has being taken from other part of the ABC's that means that there's another place in the code to fix. | |
| src/seeder/netbase.cpp | ||
| 835 | fair | |
| src/seeder/serialize.h | ||
| 135 | fair | |