Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc12ec9d8c98f: [backport#15891] test: Require standard txs in regtest by default
rABCc12ec9d8c98f: [backport#15891] test: Require standard txs in regtest by default

Summary

fa89badf887dcc01e5bdece248b5e7d234fee227 test: Require standard txs in regtest (MarcoFalke)
fa9b4191609c3ef75e69d391eb91e4d5c1e0bcf5 test: Add test that mainnet requires standard txs (MarcoFalke)
fa613ca0a8f99c4771859de9e571878530d3ecb5 chainparams: Remove unused fMineBlocksOnDemand (MarcoFalke)

Pull request description:

I don't see a reason why regtest should allow non-standard txs, as it makes testing mainnet behaviour such as #15846 unnecessarily hard and unintuitive.

Of course, testnet policy remains unchanged to allow propagation of non-standard txs.

ACKs for top commit:

ajtowns:
  ACK fa89badf887dcc01e5bdece248b5e7d234fee227

Tree-SHA512: c4c675affb054868850bd2683aa07f4c741a448cbacb2ea8334191e105f426b0790fe6a468be61e9c5880d24154f7bf1c7075051697172dce92180c1bc3a1c90

This is a backport of Core PR15891, plus changing our own tests to allow for non-standard transactions and prevent them from failing under the new rule.

Test Plan

ninja check
./test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 17 2020, 16:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 16:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Please mark this as change planned or remove the WIP tag.

This revision now requires changes to proceed.Apr 17 2020, 16:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

removing from review pipeline

Harbormaster failed remote builds in B10279: Diff 18916!Apr 17 2020, 17:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.gettime
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.util_time_GetTime
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_IsDigit
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt32
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt64
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt32
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt64
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseDouble
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatParagraph
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatSubVersion
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseFixedPoint
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_threadnames_tests.util_threadnames_test_rename_threaded
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.scan_for_wallet_transactions
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importmulti_rescan
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt
[17:14:13]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt
[17:14:17]W:	 [Step 1/2] Process exited with code 1
[17:14:17]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

rebased and added "-allownonstdtxn=1" to abc tests created before #15891 regtest change

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta retitled this revision from [WIP][backport#15891] test: Require standard txs in regtest by default to [backport#15891] test: Require standard txs in regtest by default.Apr 18 2020, 10:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 312, in assert_debug_log
    yield
  File "/work/test/functional/test_framework/mininode.py", line 639, in send_txs_and_test
    self.wait_for_disconnect()
  File "/work/test/functional/test_framework/mininode.py", line 418, in wait_for_disconnect
    wait_until(test_function, timeout=timeout, lock=mininode_lock)
  File "/work/test/functional/test_framework/util.py", line 266, in wait_until
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate (['        def test_function(): return not self.is_connected\n'], 417) not true after 60 seconds

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/p2p_invalid_tx.py", line 179, in run_test
    [tx1], node, success=False, reject_reason="{} from peer=0 was not accepted: mandatory-script-verify-flag-failed (Invalid OP_IF construction) (code 16)".format(tx1.hash), expect_disconnect=True)
  File "/work/test/functional/test_framework/mininode.py", line 653, in send_txs_and_test
    tx.hash)
  File "/usr/lib/python3.7/contextlib.py", line 130, in __exit__
    self.gen.throw(type, value, traceback)
  File "/work/test/functional/test_framework/test_node.py", line 322, in assert_debug_log
    'Expected message "{}" does not partially match log:\n\n{}\n\n'.format(expected_msg, print_log))
  File "/work/test/functional/test_framework/test_node.py", line 146, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "15fcb0773a4038a56e4447eb1f993ee7e6472a178a1874cb0632d08f0fd78a11 from peer=0 was not accepted: mandatory-script-verify-flag-failed (Invalid OP_IF construction) (code 16)" does not partially match log:

 - 2020-04-18T10:12:09.628418Z received: tx (105 bytes) peer=0
 - 2020-04-18T10:12:09.628545Z 15fcb0773a4038a56e4447eb1f993ee7e6472a178a1874cb0632d08f0fd78a11 from peer=0 was not accepted: scriptsig-not-pushonly (code 64)


2020-04-18T10:13:09.703000Z TestFramework (INFO): Stopping nodes
2020-04-18T10:13:09.908000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200418_101008/p2p_invalid_tx_485
2020-04-18T10:13:09.908000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200418_101008/p2p_invalid_tx_485/test_framework.log
2020-04-18T10:13:09.909000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200418_101008/p2p_invalid_tx_485' to consolidate all logs
[10:13:16]E:	 [Step 1/2] Failed tests detected
[10:13:12]i:		 [Bitcoin ABC functional tests] wallet_basic.py
[10:13:12]i:			 [wallet_basic.py] [Test Output]
2020-04-18T10:10:12.358000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200418_101008/wallet_basic_393
2020-04-18T10:10:13.766000Z TestFramework (INFO): Mining blocks...
2020-04-18T10:10:13.847000Z TestFramework (INFO): test gettxout
2020-04-18T10:10:13.888000Z TestFramework (INFO): test gettxout (second part)
2020-04-18T10:10:22.132000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/wallet_basic.py", line 279, in run_test
    self.nodes[1].sendrawtransaction(signedRawTx['hex'])
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 151, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: dust (code 64) (-26)
2020-04-18T10:10:22.184000Z TestFramework (INFO): Stopping nodes
2020-04-18T10:10:22.445000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200418_101008/wallet_basic_393
2020-04-18T10:10:22.445000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200418_101008/wallet_basic_393/test_framework.log
2020-04-18T10:10:22.445000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200418_101008/wallet_basic_393' to consolidate all logs
[10:13:16]W:	 [Step 1/2] Process exited with code 1
[10:13:16]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_invalid_tx.py
Bitcoin ABC functional tests: wallet_basic.py

Harbormaster failed remote builds in B10294: Diff 18937!Apr 18 2020, 10:13

You are missing the release notes.

test/functional/feature_maxuploadtarget.py
42 ↗	(On Diff #18937)	Revert

This revision now requires changes to proceed.Apr 18 2020, 10:16

added release notes, readded missing comment, fixed divergence from backport in -maxuploadtarget

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster failed remote builds in B10295: Diff 18938!Apr 18 2020, 11:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-04-18T11:26:58.695000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_node.py", line 312, in assert_debug_log
    yield
  File "/work/test/functional/test_framework/mininode.py", line 639, in send_txs_and_test
    self.wait_for_disconnect()
  File "/work/test/functional/test_framework/mininode.py", line 418, in wait_for_disconnect
    wait_until(test_function, timeout=timeout, lock=mininode_lock)
  File "/work/test/functional/test_framework/util.py", line 266, in wait_until
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate (['        def test_function(): return not self.is_connected\n'], 417) not true after 60 seconds

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/p2p_invalid_tx.py", line 179, in run_test
    [tx1], node, success=False, reject_reason="{} from peer=0 was not accepted: mandatory-script-verify-flag-failed (Invalid OP_IF construction) (code 16)".format(tx1.hash), expect_disconnect=True)
  File "/work/test/functional/test_framework/mininode.py", line 653, in send_txs_and_test
    tx.hash)
  File "/usr/lib/python3.7/contextlib.py", line 130, in __exit__
    self.gen.throw(type, value, traceback)
  File "/work/test/functional/test_framework/test_node.py", line 322, in assert_debug_log
    'Expected message "{}" does not partially match log:\n\n{}\n\n'.format(expected_msg, print_log))
  File "/work/test/functional/test_framework/test_node.py", line 146, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "e5eb0ea292f325f4860076c9e92bcd13bf4bc91f841851d0dfcce5e9fea09d2f from peer=0 was not accepted: mandatory-script-verify-flag-failed (Invalid OP_IF construction) (code 16)" does not partially match log:

 - 2020-04-18T11:25:58.674241Z received: tx (105 bytes) peer=0
 - 2020-04-18T11:25:58.674751Z e5eb0ea292f325f4860076c9e92bcd13bf4bc91f841851d0dfcce5e9fea09d2f from peer=0 was not accepted: scriptsig-not-pushonly (code 64)


2020-04-18T11:26:58.747000Z TestFramework (INFO): Stopping nodes
2020-04-18T11:26:58.950000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200418_112351/p2p_invalid_tx_142
2020-04-18T11:26:58.950000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200418_112351/p2p_invalid_tx_142/test_framework.log
2020-04-18T11:26:58.950000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200418_112351/p2p_invalid_tx_142' to consolidate all logs
[11:27:01]i:		 [Bitcoin ABC functional tests] wallet_basic.py
[11:27:01]i:			 [wallet_basic.py] [Test Output]
2020-04-18T11:23:55.141000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200418_112351/wallet_basic_50
2020-04-18T11:23:56.282000Z TestFramework (INFO): Mining blocks...
2020-04-18T11:23:57.456000Z TestFramework (INFO): test gettxout
2020-04-18T11:23:58.493000Z TestFramework (INFO): test gettxout (second part)
2020-04-18T11:24:09.631000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/wallet_basic.py", line 279, in run_test
    self.nodes[1].sendrawtransaction(signedRawTx['hex'])
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 151, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: dust (code 64) (-26)
2020-04-18T11:24:09.685000Z TestFramework (INFO): Stopping nodes
2020-04-18T11:24:09.948000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200418_112351/wallet_basic_50
2020-04-18T11:24:09.948000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200418_112351/wallet_basic_50/test_framework.log
2020-04-18T11:24:09.948000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200418_112351/wallet_basic_50' to consolidate all logs
[11:27:05]W:	 [Step 1/2] Process exited with code 1
[11:27:05]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_maxuploadtarget.py
Bitcoin ABC functional tests: p2p_invalid_tx.py
Bitcoin ABC functional tests: wallet_basic.py

The test suite is still broken.

This revision now requires changes to proceed.Apr 18 2020, 13:30

fixed broken test suite

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

readded missing comment on test/functional/feature_maxuploadtarget.py

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the test plan for this revision. (Show Details)Apr 20 2020, 03:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-04-20T04:01:50.364000Z TestFramework (INFO): Create some blocks with OP_1 coinbase for spending.
2020-04-20T04:01:50.488000Z TestFramework (INFO): Mature the blocks.
2020-04-20T04:01:50.537000Z TestFramework (INFO): Generating some high-sigop transactions.
2020-04-20T04:01:50.538000Z TestFramework (INFO): Try various high-sigop transactions in blocks / mempool before upgrade
2020-04-20T04:01:50.590000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/abc-sigops-deactivation.py", line 234, in run_test
    check_for_no_ban_on_rejected_tx(node, tx_4001, MEMPOOL_TXSIGOPS_ERROR)
  File "/work/test/functional/abc-sigops-deactivation.py", line 121, in check_for_no_ban_on_rejected_tx
    [tx], node, success=False, reject_reason=reject_reason)
  File "/work/test/functional/test_framework/mininode.py", line 653, in send_txs_and_test
    tx.hash)
  File "/usr/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 322, in assert_debug_log
    'Expected message "{}" does not partially match log:\n\n{}\n\n'.format(expected_msg, print_log))
  File "/work/test/functional/test_framework/test_node.py", line 146, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "bad-txns-too-many-sigops" does not partially match log:

 - 2020-04-20T04:01:50.539177Z received: tx (271 bytes) peer=2
 - 2020-04-20T04:01:50.539278Z a26bbd2a143e6057fc748513db38af75443955e4eb58e3cd27dbd3a02bbe2498 from peer=2 was not accepted: scriptpubkey (code 64)
 - 2020-04-20T04:01:50.539286Z sending reject (49 bytes) peer=2
 - 2020-04-20T04:01:50.539321Z received: ping (8 bytes) peer=2
 - 2020-04-20T04:01:50.539330Z sending pong (8 bytes) peer=2
 - 2020-04-20T04:01:50.589601Z Received a POST request for / from 127.0.0.1:53628
 - 2020-04-20T04:01:50.589674Z ThreadRPCServer method=getrawmempool


2020-04-20T04:01:50.641000Z TestFramework (INFO): Stopping nodes
2020-04-20T04:01:50.793000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-deactivation_182
2020-04-20T04:01:50.793000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-deactivation_182/test_framework.log
2020-04-20T04:01:50.793000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-deactivation_182' to consolidate all logs
[04:02:17]i:		 [Bitcoin ABC functional tests] abc-sigops-mempool-mining.py
[04:02:17]i:			 [abc-sigops-mempool-mining.py] [Test Output]
2020-04-20T04:01:41.369000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-mempool-mining_169
2020-04-20T04:01:41.686000Z TestFramework (INFO): Create some blocks with OP_1 coinbase for spending.
2020-04-20T04:01:42.281000Z TestFramework (INFO): Mature the blocks and get out of IBD; also make some coinbases for the node wallet.
2020-04-20T04:01:42.411000Z TestFramework (INFO): PART 1: testing of priority under congestion (mempool eviction priority and mining priority).
2020-04-20T04:01:42.411000Z TestFramework (INFO): Put a regular transaction in mempool at 1 sat/byte.
2020-04-20T04:01:42.426000Z TestFramework (INFO): Mempool accepts 1 sat/byte txes even with very many sigops
2020-04-20T04:01:42.427000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/abc-sigops-mempool-mining.py", line 181, in run_test
    txid_parent = node.sendrawtransaction(ToHex(ctx))
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 151, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: scriptpubkey (code 64) (-26)
2020-04-20T04:01:42.478000Z TestFramework (INFO): Stopping nodes
2020-04-20T04:01:42.782000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-mempool-mining_169
2020-04-20T04:01:42.782000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-mempool-mining_169/test_framework.log
2020-04-20T04:01:42.782000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200420_035956/abc-sigops-mempool-mining_169' to consolidate all logs
[04:02:23]W:	 [Step 1/2] Process exited with code 1
[04:02:23]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Harbormaster failed remote builds in B10298: Diff 18941!Apr 20 2020, 04:02

majcosta planned changes to this revision.Apr 20 2020, 04:07

majcosta edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B10299: Diff 18942!Apr 20 2020, 04:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-04-20T04:07:43.080000Z TestFramework (INFO): Create some blocks with OP_1 coinbase for spending.
2020-04-20T04:07:43.197000Z TestFramework (INFO): Mature the blocks.
2020-04-20T04:07:43.274000Z TestFramework (INFO): Generating some high-sigop transactions.
2020-04-20T04:07:43.276000Z TestFramework (INFO): Try various high-sigop transactions in blocks / mempool before upgrade
2020-04-20T04:07:43.328000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/abc-sigops-deactivation.py", line 234, in run_test
    check_for_no_ban_on_rejected_tx(node, tx_4001, MEMPOOL_TXSIGOPS_ERROR)
  File "/work/test/functional/abc-sigops-deactivation.py", line 121, in check_for_no_ban_on_rejected_tx
    [tx], node, success=False, reject_reason=reject_reason)
  File "/work/test/functional/test_framework/mininode.py", line 653, in send_txs_and_test
    tx.hash)
  File "/usr/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 322, in assert_debug_log
    'Expected message "{}" does not partially match log:\n\n{}\n\n'.format(expected_msg, print_log))
  File "/work/test/functional/test_framework/test_node.py", line 146, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "bad-txns-too-many-sigops" does not partially match log:

 - 2020-04-20T04:07:43.277616Z received: tx (271 bytes) peer=2
 - 2020-04-20T04:07:43.277723Z ad0b7455db67392acc8dadcfc339ae154601608bcbd9a0ea047857ac60503111 from peer=2 was not accepted: scriptpubkey (code 64)
 - 2020-04-20T04:07:43.277731Z sending reject (49 bytes) peer=2
 - 2020-04-20T04:07:43.277761Z received: ping (8 bytes) peer=2
 - 2020-04-20T04:07:43.277769Z sending pong (8 bytes) peer=2
 - 2020-04-20T04:07:43.327783Z Received a POST request for / from 127.0.0.1:33980
 - 2020-04-20T04:07:43.327848Z ThreadRPCServer method=getrawmempool


2020-04-20T04:07:43.379000Z TestFramework (INFO): Stopping nodes
2020-04-20T04:07:43.531000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-deactivation_167
2020-04-20T04:07:43.531000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-deactivation_167/test_framework.log
2020-04-20T04:07:43.532000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-deactivation_167' to consolidate all logs
[04:08:09]i:		 [Bitcoin ABC functional tests] abc-sigops-mempool-mining.py
[04:08:09]i:			 [abc-sigops-mempool-mining.py] [Test Output]
2020-04-20T04:07:35.191000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-mempool-mining_154
2020-04-20T04:07:35.500000Z TestFramework (INFO): Create some blocks with OP_1 coinbase for spending.
2020-04-20T04:07:36.099000Z TestFramework (INFO): Mature the blocks and get out of IBD; also make some coinbases for the node wallet.
2020-04-20T04:07:36.212000Z TestFramework (INFO): PART 1: testing of priority under congestion (mempool eviction priority and mining priority).
2020-04-20T04:07:36.212000Z TestFramework (INFO): Put a regular transaction in mempool at 1 sat/byte.
2020-04-20T04:07:36.230000Z TestFramework (INFO): Mempool accepts 1 sat/byte txes even with very many sigops
2020-04-20T04:07:36.231000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 162, in main
    self.run_test()
  File "/work/test/functional/abc-sigops-mempool-mining.py", line 181, in run_test
    txid_parent = node.sendrawtransaction(ToHex(ctx))
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 151, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: scriptpubkey (code 64) (-26)
2020-04-20T04:07:36.281000Z TestFramework (INFO): Stopping nodes
2020-04-20T04:07:36.332000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-mempool-mining_154
2020-04-20T04:07:36.332000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-mempool-mining_154/test_framework.log
2020-04-20T04:07:36.333000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/bitcoin_test_runner_20200420_040557/abc-sigops-mempool-mining_154' to consolidate all logs
[04:08:16]W:	 [Step 1/2] Process exited with code 1
[04:08:16]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)