Page MenuHomePhabricator

[backport#12916] Introduce BigEndian wrapper and use it for netaddress ports
ClosedPublic

Authored by majcosta on Apr 21 2020, 23:00.

Details

Summary

This is another small improvement taken from #10785.

Instead of manually converting from/to BE format in the CService serializer, provide a generic way in serialize.h to serialize BE data (only 16 bits for now).


This is a backport of Core PR12916

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bigendian_wrapper
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10337
Build 18495: Default Diff Build & Tests
Build 18494: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 22 2020, 08:07