Page MenuHomePhabricator
Differential D5799

[backport#12916] Introduce BigEndian wrapper and use it for netaddress ports
ClosedPublic
Actions

Authored by majcosta on Apr 21 2020, 23:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING334205c83df6: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports
rABC334205c83df6: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports
Summary

This is another small improvement taken from #10785.

Instead of manually converting from/to BE format in the CService serializer, provide a generic way in serialize.h to serialize BE data (only 16 bits for now).

This is a backport of Core PR12916

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 21 2020, 23:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 23:00
teamcity edited the summary of this revision. (Show Details)Apr 21 2020, 23:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 21 2020, 23:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 21 2020, 23:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10337: Diff 19006.Apr 21 2020, 23:13
Fabien accepted this revision.Apr 22 2020, 08:07
This revision is now accepted and ready to land.Apr 22 2020, 08:07
Closed by commit rABC334205c83df6: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyApr 22 2020, 17:05
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC334205c83df6: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports.
majcosta added a commit: rSTAGING334205c83df6: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports.May 5 2020, 19:04

Revision Contents
Changeset List

PathSize
src/
8 lines
46 lines

Diff 19020

View Options

src/netaddress.h

Loading...
View Options

src/serialize.h

Loading...