Page MenuHomePhabricator

Remove CheckFinalTx
ClosedPublic

Authored by Fabien on Apr 22 2020, 13:19.

Details

Summary

This is a follow-up for D144. It converts the wallet to use
ContextualCheckTransactionForCurrentBlock() instead of the
CheckFinalTx() wrapper and removes the unused finaltx.cpp/h files.

This is a preamble to backporting PR15288 which will remove the direct call to CheckFinalTx in the wallet (this commit).
Having both CheckFinalTx and ContextualCheckTransactionForCurrentBlock is error prone when doing the node/wallet separation backports. This cleanup make it easier to backport and review.
Note that the above commit will allow to remove some of the boilerplate introduced in this diff.

Test Plan
ninja all check check-functional

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallet_checkfinaltx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10342
Build 18505: Default Diff Build & Tests
Build 18504: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Apr 22 2020, 13:54
deadalnix added a subscriber: deadalnix.

What problem does this solve?

This revision now requires changes to proceed.Apr 22 2020, 13:54

Updated the summary to explain why I want to do this.

Fabien requested review of this revision.Apr 22 2020, 15:01
This revision is now accepted and ready to land.Apr 22 2020, 20:18
This revision was automatically updated to reflect the committed changes.