Differential D5996

move-only: make the CChainState interface public
ClosedPublic
Actions

Authored by deadalnix on May 7 2020, 17:16.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7487045167a8: move-only: make the CChainState interface public
rABC7487045167a8: move-only: make the CChainState interface public

Summary

along with DisconnectResult, and CBlockIndexWorkComparator.

The CChainState interface needs to be known to the rest of the system because
many global functions will move to CChainState methods. This is to allow
other parts of the system to be parameterized per chainstate instance
instead of assuming a single global.

This is a partial backport of Core PR15976 : https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15976-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10637
Build 19081: Default Diff Build & Tests
Build 19080: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 7 2020, 17:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 17:16

deadalnix requested review of this revision.May 7 2020, 17:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10637: Diff 19801.May 7 2020, 17:28

jasonbcox accepted this revision.May 7 2020, 18:30

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/validation.h
743	Nit: This is a good opportunity to shuffle this further down to match Core better.

This revision is now accepted and ready to land.May 7 2020, 18:30

rebase

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D6001: refactoring: introduce ChainstateActive().May 7 2020, 18:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10643: Diff 19811.May 7 2020, 18:59

Closed by commit rABC7487045167a8: move-only: make the CChainState interface public (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyMay 7 2020, 19:24

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7487045167a8: move-only: make the CChainState interface public.

deadalnix added a commit: rSTAGING7487045167a8: move-only: make the CChainState interface public.

Revision Contents
Changeset List

Path

Size

src/

177 lines

172 lines

Diff 19801

src/validation.h

Loading...

src/validation.cpp

Loading...