Page MenuHomePhabricator
Differential D6001

refactoring: introduce ChainstateActive()
ClosedPublic
Actions

Authored by deadalnix on May 7 2020, 18:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING570f1a6731e2: refactoring: introduce ChainstateActive()
rABC570f1a6731e2: refactoring: introduce ChainstateActive()
Summary

To be used once we move global functions (e.g. FlushStateToDisk()) into
CChainState methods.

Thanks to Marco Falke for suggestions

This is a partial backport of Core PR15976 : https://github.com/bitcoin/bitcoin/pull/15976/commits/4d6688603b8c8df854d52df464e157d0a6e7bde6

Depends on D5996

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 7 2020, 18:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 18:49
deadalnix requested review of this revision.May 7 2020, 18:49
teamcity edited the summary of this revision. (Show Details)May 7 2020, 18:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 7 2020, 18:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D6002: refactoring: FlushStateToDisk -> CChainState.May 7 2020, 18:55
teamcity added a comment.May 7 2020, 19:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10644: Diff 19812.May 7 2020, 19:05
jasonbcox accepted this revision.May 7 2020, 19:13
This revision is now accepted and ready to land.May 7 2020, 19:13
Closed by commit rABC570f1a6731e2: refactoring: introduce ChainstateActive() (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyMay 7 2020, 19:30
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC570f1a6731e2: refactoring: introduce ChainstateActive().
deadalnix added a commit: rSTAGING570f1a6731e2: refactoring: introduce ChainstateActive().

Revision Contents
Changeset List

PathSize
src/
3 lines
64 lines

Diff 19822

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...