Page MenuHomePhabricator
Differential D6035

refactoring: IsInitialBlockDownload -> CChainState
ClosedPublic
Actions

Authored by deadalnix on May 11 2020, 19:55.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGINGea63f129f964: refactoring: IsInitialBlockDownload -> CChainState
rABCea63f129f964: refactoring: IsInitialBlockDownload -> CChainState
Summary

We introduce CChainState.m_cached_finished_ibd because the static state it
replaces would've been shared across all CChainState instances.

This is a partial backport of Core PR15976 : https://github.com/bitcoin/bitcoin/pull/15976/commits/403e677c9ebbf9744733010e6b0c2d1b182ee850

Depends on D6002

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 11 2020, 19:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 19:55
deadalnix requested review of this revision.May 11 2020, 19:55
teamcity edited the summary of this revision. (Show Details)May 11 2020, 19:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 11 2020, 19:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 11 2020, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10701: Diff 19923.May 11 2020, 20:05
majcosta accepted this revision.May 11 2020, 23:31
This revision is now accepted and ready to land.May 11 2020, 23:31
Closed by commit rABCea63f129f964: refactoring: IsInitialBlockDownload -> CChainState (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyMay 11 2020, 23:37
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCea63f129f964: refactoring: IsInitialBlockDownload -> CChainState.
deadalnix added a commit: rSTAGINGea63f129f964: refactoring: IsInitialBlockDownload -> CChainState.May 11 2020, 23:40

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
2 lines
25 lines
rpc/
3 lines
6 lines
20 lines
28 lines

Diff 19933

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...