Page MenuHomePhabricator
Differential D6002

refactoring: FlushStateToDisk -> CChainState
ClosedPublic
Actions

Authored by deadalnix on May 7 2020, 18:55.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING86da53b15882: refactoring: FlushStateToDisk -> CChainState
rABC86da53b15882: refactoring: FlushStateToDisk -> CChainState
Summary

Also renames global methods for clarity:

  • ::FlushStateToDisk() -> CChainState::ForceFlushStateToDisk()
    • This performs an unconditional flush.
  • ::PruneAndFlush() -> CChainState::PruneAndFlush()

This is a partial backport of Core PR15976 : https://github.com/bitcoin/bitcoin/pull/15976/commits/3ccbc376dd313fb7666471f24f6d9370914d00f3

Depends on D6001

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 7 2020, 18:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 18:55
deadalnix requested review of this revision.May 7 2020, 18:55
teamcity edited the summary of this revision. (Show Details)May 7 2020, 18:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 7 2020, 18:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 7 2020, 19:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10645: Diff 19813.May 7 2020, 19:06
jasonbcox accepted this revision.May 7 2020, 19:27
This revision is now accepted and ready to land.May 7 2020, 19:27
Closed by commit rABC86da53b15882: refactoring: FlushStateToDisk -> CChainState (authored by James O'Beirne <james.obeirne@gmail.com>, committed by deadalnix). · Explain WhyMay 7 2020, 20:15
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC86da53b15882: refactoring: FlushStateToDisk -> CChainState.
deadalnix added a commit: rSTAGING86da53b15882: refactoring: FlushStateToDisk -> CChainState.
deadalnix added a child revision: D6035: refactoring: IsInitialBlockDownload -> CChainState.May 11 2020, 19:55

Revision Contents
Changeset List

PathSize
src/
6 lines
rpc/
4 lines
29 lines
38 lines

Diff 19826

View Options

src/init.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...