Page MenuHomePhabricator
Differential D6128

[backport#15153] gui: Add OpenWalletActivity
ClosedPublic
Actions

Authored by majcosta on May 18 2020, 23:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING756d5ab4ae79: [backport#15153] gui: Add OpenWalletActivity
rABC756d5ab4ae79: [backport#15153] gui: Add OpenWalletActivity
Summary

https://github.com/bitcoin/bitcoin/pull/15153/commits/8847cdaaaeb45c1ddee89f43ac4b8fafb20e5c0d

Depends on D6121

This is a partial backport of Core PR15153

Test Plan
as D6115

Diff Detail

Event Timeline

majcosta created this revision.May 18 2020, 23:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 23:09
majcosta requested review of this revision.May 18 2020, 23:09
teamcity edited the summary of this revision. (Show Details)May 18 2020, 23:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 18 2020, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 23:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

majcosta added a child revision: D6129: [backport#15153] gui: Show indeterminate progress dialog while opening wallet.May 18 2020, 23:15
teamcity added a comment.May 18 2020, 23:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10840: Diff 20247.May 18 2020, 23:20
deadalnix requested changes to this revision.May 18 2020, 23:45
deadalnix added a subscriber: deadalnix.

There is new behavior vs D6115 so the test plan must reflect this.

This revision now requires changes to proceed.May 18 2020, 23:45
deadalnix accepted this revision.May 19 2020, 15:33
This revision is now accepted and ready to land.May 19 2020, 15:33
Closed by commit rABC756d5ab4ae79: [backport#15153] gui: Add OpenWalletActivity (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 19 2020, 16:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC756d5ab4ae79: [backport#15153] gui: Add OpenWalletActivity.
majcosta added a commit: rSTAGING756d5ab4ae79: [backport#15153] gui: Add OpenWalletActivity.May 19 2020, 17:00

Revision Contents
Changeset List

PathSize
src/
qt/
1 line
9 lines
31 lines
45 lines

Diff 20247

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...