Page MenuHomePhabricator
Differential D6172

[backport#16231] gui: Fix open wallet menu initialization order
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 18:56.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING27ebbd764ce8: [backport#16231] gui: Fix open wallet menu initialization order
rABC27ebbd764ce8: [backport#16231] gui: Fix open wallet menu initialization order
Summary

The menu must be created before connecting to aboutToShow signal.

https://github.com/bitcoin/bitcoin/pull/16231/commits/5224be5a3354e1a22ea4d7f0e40aadfccdf67064

Depends on D6170

Backport of Core PR16231

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 18:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 18:56
majcosta requested review of this revision.May 20 2020, 18:56
teamcity edited the summary of this revision. (Show Details)May 20 2020, 18:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 18:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 19:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 19:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10905: Diff 20380.May 20 2020, 19:13
majcosta added a child revision: D6174: [backport#16106] gui: Sort wallets in open wallet menu.May 20 2020, 19:24
jasonbcox accepted this revision.May 20 2020, 21:45
This revision is now accepted and ready to land.May 20 2020, 21:45
Closed by commit rABC27ebbd764ce8: [backport#16231] gui: Fix open wallet menu initialization order (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 00:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC27ebbd764ce8: [backport#16231] gui: Fix open wallet menu initialization order.
majcosta added a commit: rSTAGING27ebbd764ce8: [backport#16231] gui: Fix open wallet menu initialization order.

Revision Contents
Changeset List

PathSize
src/
qt/
1 line
13 lines

Diff 20419

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...