Page MenuHomePhabricator
Differential D6179

[backport#15091] Qt: update header count regardless of update delay
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 22:00.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCdbd6d0c8a1c4: [backport#15091] Qt: update header count regardless of update delay
Summary

https://github.com/bitcoin/bitcoin/pull/15091/commits/7bb45e4b7a71e0ff0e2bbeba5367022758efa5d4

Depends on D6177

Partial backport of Core PR15091

Test Plan
ninja
./src/qt/bitcoin-qt

In a node that isn't 100% synced, see that overlay describes it is receiving headers,
and then blocks correctly.

Diff Detail

Event Timeline

majcosta created this revision.May 20 2020, 22:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 22:00
majcosta requested review of this revision.May 20 2020, 22:00
teamcity edited the summary of this revision. (Show Details)May 20 2020, 22:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 22:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 22:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 22:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 22:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 22:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 22:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10913: Diff 20392.May 20 2020, 22:10
majcosta added a child revision: D6180: [backport#15091] Qt: Fix update headers-count.May 20 2020, 22:21
jasonbcox accepted this revision.May 20 2020, 22:44
This revision is now accepted and ready to land.May 20 2020, 22:44
Closed by commit rABCdbd6d0c8a1c4: [backport#15091] Qt: update header count regardless of update delay (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by majcosta). · Explain WhyMay 21 2020, 01:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCdbd6d0c8a1c4: [backport#15091] Qt: update header count regardless of update delay.

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines

Diff 20392

View Options

src/qt/clientmodel.cpp

Loading...