Page MenuHomePhabricator
Differential D6184

[backport#16349] Remove redundant WalletController::addWallet slot
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 22:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd7437bcdf746: [backport#16349] Remove redundant WalletController::addWallet slot
Summary

https://github.com/bitcoin/bitcoin/pull/16349/commits/6285a318d77dbfdf50f893963ebfb2973746f757

Depends on D6183

Backport of Core PR16349

Test Plan
ninja check
./srt/qt/bitcoin-qt -regtest

check the UI works as expected, close the default wallet, open the default wallet

Diff Detail

Event Timeline

majcosta created this revision.May 20 2020, 22:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 22:45
majcosta requested review of this revision.May 20 2020, 22:45
teamcity edited the summary of this revision. (Show Details)May 20 2020, 22:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 22:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 22:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 22:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10919: Diff 20401.May 20 2020, 22:56
deadalnix accepted this revision.May 21 2020, 00:08
This revision is now accepted and ready to land.May 21 2020, 00:08
Closed by commit rABCd7437bcdf746: [backport#16349] Remove redundant WalletController::addWallet slot (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by majcosta). · Explain WhyMay 21 2020, 01:10
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd7437bcdf746: [backport#16349] Remove redundant WalletController::addWallet slot.

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines
22 lines

Diff 20401

View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...