Use IsDigit(...) instead of std::isdigit
Use ToLower(...) instead of std::tolower
Use IsSpace(...) instead of boost::is_space
Update KNOWN_VIOLATIONS: Remove fixed violations
Backport of Core PR14599
Details
Details
- Reviewers
jasonbcox deadalnix - Group Reviewers
Restricted Project - Commits
- rABC52379b02de1e: [backport#14599] Use functions guaranteed to be locale independent
ninja check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 11103 Build 20684: Default Diff Build & Tests Build 20683: Build without Wallet Build 20682: Build with clang-10 Build 20681: arc lint + arc unit
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Comment Actions
Are the missed changes in LocaleDependenceLinter due to missing backports? If so, why not do those first?
| src/uint256.cpp | ||
|---|---|---|
| 33 ↗ | (On Diff #20707) | cast should be function style: uint8_t(...) |
| src/uint256.cpp | ||
|---|---|---|
| 33 ↗ | (On Diff #20706) | C++ constructor instead of C cast |
Comment Actions
I've looked for them, but didn't find them. Looks like a legit mistake or they reintroduced them later. They're calling strtoll and strtoull in util/strencodings.cpp today.
| src/uint256.cpp | ||
|---|---|---|
| 33 | You did change the behavior here, and it's fishy tests are passing. You might want to use that opportunity to add a handful of test cases. | |