Page MenuHomePhabricator
Differential D6337

index: Implement block filter index with write operations.
ClosedPublic
Actions

Authored by deadalnix on Jun 2 2020, 22:57.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC12fb82482020: index: Implement block filter index with write operations.
Summary

This is a partial backport of Core PR14121 : https://github.com/bitcoin/bitcoin/pull/14121/commits/75a76e36199eba228856d59318cb54ca64ca6b57

Depends on D6335 and D6333

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 2 2020, 22:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 22:57
deadalnix requested review of this revision.Jun 2 2020, 22:57
teamcity edited the summary of this revision. (Show Details)Jun 2 2020, 22:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11153: Diff 20816.Jun 2 2020, 23:06
deadalnix added a child revision: D6339: index: Implement lookup methods on block filter index..Jun 2 2020, 23:22
jasonbcox requested changes to this revision.Jun 3 2020, 00:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/index/blockfilterindex.cpp
10 ↗(On Diff #20816)

include ordering/grouping: associated header, other ABC headers, third-party

This revision now requires changes to proceed.Jun 3 2020, 00:49
deadalnix updated this revision to Diff 20828.Jun 3 2020, 11:51

Rebase and reorder includes

Harbormaster completed remote builds in B11158: Diff 20828.Jun 3 2020, 12:05
jasonbcox accepted this revision.Jun 3 2020, 15:26
jasonbcox added inline comments.
src/index/blockfilterindex.cpp
5 ↗(On Diff #20828)

should be a newline after this one

This revision is now accepted and ready to land.Jun 3 2020, 15:26
Closed by commit rABC12fb82482020: index: Implement block filter index with write operations. (authored by jimpo, committed by deadalnix). · Explain WhyJun 3 2020, 16:45
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC12fb82482020: index: Implement block filter index with write operations..

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
index/
54 lines
304 lines

Diff 20833

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/index/blockfilterindex.h

Loading...
View Options

src/index/blockfilterindex.cpp

Loading...