Page MenuHomePhabricator

index: Implement block filter index with write operations.
ClosedPublic

Authored by deadalnix on Jun 2 2020, 22:57.

Details

Summary
Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jun 2 2020, 22:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2020, 22:57
deadalnix requested review of this revision.Jun 2 2020, 22:57
teamcity edited the summary of this revision. (Show Details)Jun 2 2020, 22:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Jun 3 2020, 00:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/index/blockfilterindex.cpp
10 ↗(On Diff #20816)

include ordering/grouping: associated header, other ABC headers, third-party

This revision now requires changes to proceed.Jun 3 2020, 00:49
deadalnix updated this revision to Diff 20828.Jun 3 2020, 11:51

Rebase and reorder includes

jasonbcox accepted this revision.Jun 3 2020, 15:26
jasonbcox added inline comments.
src/index/blockfilterindex.cpp
5 ↗(On Diff #20828)

should be a newline after this one

This revision is now accepted and ready to land.Jun 3 2020, 15:26
This revision was automatically updated to reflect the committed changes.