rpc: Add getblockfilter RPC method.
ClosedPublic
Actions

Authored by deadalnix on Jun 3 2020, 19:20.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCf79742f8f978: rpc: Add getblockfilter RPC method.

Summary

Retrieves and returns block filter and header from index.

This is a partial backport of Core PR14121 : https://github.com/bitcoin/bitcoin/pull/14121/commits/19308c9e21d98a7818625218b22b37f23f87816f

Depends on D6346

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 3 2020, 19:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2020, 19:20

deadalnix requested review of this revision.Jun 3 2020, 19:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11168: Diff 20842.Jun 3 2020, 19:33

deadalnix added a child revision: D6351: blockfilter: Update BIP 158 test vectors..Jun 3 2020, 22:26

Looks fine, but please investigate why the linter was not applied to the imports.

test/functional/rpc_getblockfilter.py
10 ↗	(On Diff #20842)	Did the linter not catch/fix this? Each of these imports should be on their own line.

This revision is now accepted and ready to land.Jun 3 2020, 23:48

rebase

Harbormaster completed remote builds in B11188: Diff 20875.Jun 4 2020, 09:58

Closed by commit rABCf79742f8f978: rpc: Add getblockfilter RPC method. (authored by jimpo, committed by deadalnix). · Explain WhyJun 4 2020, 17:37

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf79742f8f978: rpc: Add getblockfilter RPC method..

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

86 lines

test/

functional/

rpc_getblockfilter.py

75 lines

Diff 20907

View Options

src/rpc/blockchain.cpp