Page MenuHomePhabricator
Differential D6346

init: Add CLI option to enable block filter index.
ClosedPublic
Actions

Authored by deadalnix on Jun 3 2020, 18:30.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCd5f585b407c4: init: Add CLI option to enable block filter index.
Summary

This is a partial backport of Core PR14121 : https://github.com/bitcoin/bitcoin/pull/14121/commits/ff351050968f290787cd5fa456d394380f64fec3

Depends on D6345

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 3 2020, 18:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2020, 18:30
deadalnix requested review of this revision.Jun 3 2020, 18:30
teamcity edited the summary of this revision. (Show Details)Jun 3 2020, 18:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11165: Diff 20839.Jun 3 2020, 18:41
deadalnix added a child revision: D6349: rpc: Add getblockfilter RPC method..Jun 3 2020, 19:20
jasonbcox requested changes to this revision.Jun 3 2020, 21:53
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/blockfilter.cpp
6 ↗(On Diff #20839)

standard lib includes should come after ABC includes

8 ↗(On Diff #20839)

nit: newline here to separate associated header and other ABC includes

This revision now requires changes to proceed.Jun 3 2020, 21:53
deadalnix updated this revision to Diff 20863.Jun 4 2020, 00:40

Fix headers

Harbormaster completed remote builds in B11183: Diff 20863.Jun 4 2020, 00:56
deadalnix updated this revision to Diff 20872.Jun 4 2020, 09:11

rebase

Harbormaster completed remote builds in B11186: Diff 20872.Jun 4 2020, 09:37
jasonbcox accepted this revision.Jun 4 2020, 17:06
This revision is now accepted and ready to land.Jun 4 2020, 17:06
Closed by commit rABCd5f585b407c4: init: Add CLI option to enable block filter index. (authored by jimpo, committed by deadalnix). · Explain WhyJun 4 2020, 17:32
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd5f585b407c4: init: Add CLI option to enable block filter index..

Revision Contents
Changeset List

PathSize
src/
6 lines
36 lines
55 lines
2 lines
1 line

Diff 20904

View Options

src/blockfilter.h

Loading...
View Options

src/blockfilter.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/validation.h

Loading...