Differential D6409

[backport#16839] Pass NodeContext, ConnMan, BanMan references more places
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 14:18.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC2b8b4bb8e962: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places

Summary

So g_connman and g_banman globals can be removed next commit.

https://github.com/bitcoin/bitcoin/pull/16839/commits/e6f4f895d5e42feaf7bfa5f41e80292aaa73cd7d

Partial backport of Core PR16839

Test Plan

ninja check-all
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16839

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11258
Build 21271: Default Diff Build & Tests
Build 21270: Build without Wallet
Build 21269: Build with clang-10
Build 21268: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 14:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 14:18

majcosta requested review of this revision.Jun 6 2020, 14:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11258: Diff 20994.Jun 6 2020, 14:31

deadalnix accepted this revision.Jun 6 2020, 16:37

This revision is now accepted and ready to land.Jun 6 2020, 16:37

Closed by commit rABC2b8b4bb8e962: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyJun 6 2020, 19:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC2b8b4bb8e962: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

Makefile.am

1 line

bench/

7 lines

4 lines

11 lines

4 lines

8 lines

interfaces/

3 lines

13 lines

4 lines

6 lines

12 lines

node/

17 lines

10 lines

10 lines

3 lines

qt/

test/

8 lines

13 lines

8 lines

2 lines

8 lines

8 lines

14 lines

rpc/

mining.cpp

1 line

net.cpp

1 line

rawtransaction.cpp

3 lines

test/

rpc_tests.cpp

6 lines

util/

setup_common.h

2 lines

wallet/

init.cpp

1 line

rpcwallet.cpp

2 lines

test/

coinselector_tests.cpp

5 lines

init_test_fixture.h

4 lines

ismine_tests.cpp

4 lines

wallet_test_fixture.h

4 lines

wallet_tests.cpp

19 lines

walletdb_tests.cpp

4 lines

Diff 20994

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/bench/coin_selection.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/bitcoind.cpp

View Options

src/init.h

View Options

src/init.cpp

View Options

src/interfaces/chain.h

View Options

src/interfaces/chain.cpp

View Options

src/interfaces/node.h

View Options

src/interfaces/node.cpp

View Options

src/net_processing.cpp

View Options

src/node/context.h

View Options

src/node/context.cpp

View Options

src/node/transaction.h

View Options

src/node/transaction.cpp

View Options

src/qt/test/addressbooktests.h

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/rpcnestedtests.h

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/test_main.cpp

View Options

src/qt/test/wallettests.h

View Options

src/qt/test/wallettests.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/util/setup_common.h

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/init_test_fixture.h

View Options

src/wallet/test/ismine_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp

[backport#16839] Pass NodeContext, ConnMan, BanMan references more placesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20994

src/CMakeLists.txt

src/Makefile.am

src/bench/coin_selection.cpp

src/bench/wallet_balance.cpp

src/bitcoind.cpp

src/init.h

src/init.cpp

src/interfaces/chain.h

src/interfaces/chain.cpp

src/interfaces/node.h

src/interfaces/node.cpp

src/net_processing.cpp

src/node/context.h

src/node/context.cpp

src/node/transaction.h

src/node/transaction.cpp

src/qt/test/addressbooktests.h

src/qt/test/addressbooktests.cpp

src/qt/test/rpcnestedtests.h

src/qt/test/rpcnestedtests.cpp

src/qt/test/test_main.cpp

src/qt/test/wallettests.h

src/qt/test/wallettests.cpp

src/rpc/mining.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/test/rpc_tests.cpp

src/test/util/setup_common.h

src/wallet/init.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/test/init_test_fixture.h

src/wallet/test/ismine_tests.cpp

src/wallet/test/wallet_test_fixture.h

src/wallet/test/wallet_tests.cpp

src/wallet/test/walletdb_tests.cpp

[backport#16839] Pass NodeContext, ConnMan, BanMan references more places
ClosedPublic
Actions

Revision Contents
Changeset List