Page MenuHomePhabricator
Differential D6459

Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
ClosedPublic
Actions

Authored by nakihito on Jun 8 2020, 19:50.

Details

Reviewers
majcosta
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
Summary

Partial backport of Core PR14336
https://github.com/bitcoin/bitcoin/pull/14336/commits/1e6afd0dbc1c581435588e1e9bb419a035b81028

Test Plan
ninja
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 8 2020, 19:50
Owners added a reviewer: Restricted Owners Package.Jun 8 2020, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2020, 19:50
nakihito requested review of this revision.Jun 8 2020, 19:50
nakihito planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)Jun 8 2020, 19:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Jun 8 2020, 19:53
Harbormaster completed remote builds in B11328: Diff 21109.Jun 8 2020, 20:00
majcosta accepted this revision.Jun 8 2020, 20:08
This revision is now accepted and ready to land.Jun 8 2020, 20:08
nakihito added a child revision: D6460: Move GenerateSelectSet logic to private method..Jun 8 2020, 22:14
nakihito updated this revision to Diff 21190.Jun 9 2020, 20:20

Rebased.

Harbormaster completed remote builds in B11372: Diff 21190.Jun 9 2020, 20:34
jasonbcox accepted this revision.Jun 9 2020, 22:56
Closed by commit rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. (authored by Patrick Strateman <patrick.strateman@gmail.com>, committed by nakihito). · Explain WhyJun 9 2020, 23:13
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..

Revision Contents
Changeset List

PathSize
src/
8 lines

Diff 21201

View Options

src/net.cpp

Loading...