Page MenuHomePhabricator

Update developer notes to include Arcanist setup instructions
ClosedPublic

Authored by jasonbcox on Nov 8 2017, 04:19.

Details

Summary

I didn't realize I needed to use Arcanist when submitting changes for my first diff, and I found that I couldn't commit them. Nothing in the ABC docs indicated this, so I'm adding them.

Test Plan

N/A

Diff Detail

Repository
rABC Bitcoin ABC
Branch
docs
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1073
Build 1073: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 8 2017, 04:19

arcanist is included in the debian and ubuntu repositories no need to install it manually.

deadalnix requested changes to this revision.Nov 8 2017, 22:56

Please have people use what's in the repo of their distro.

This revision now requires changes to proceed.Nov 8 2017, 22:56
jasonbcox edited edge metadata.

Removed manual installation steps and replaced with instructions per feedback.

Arc land was failing, and it seems the parent of the second diff didn't match what was in Differential for some reason. I've squashed my changes together and will try submitting those after a new approval...

Looks good.

Reading though doc/developer-notes.md I can see we need to massively re-write it for Bitcoin ABC development.

We should include things like:

  • General development philosophy and expectations (rapidly-iterating development process)
  • How to get set-up with Phabricator
  • More details on how to work with git and arcanist

But for now, this is a good start.

This revision is now accepted and ready to land.Nov 22 2017, 19:21
This revision was automatically updated to reflect the committed changes.