I didn't realize I needed to use Arcanist when submitting changes for my first diff, and I found that I couldn't commit them. Nothing in the ABC docs indicated this, so I'm adding them.
Details
Details
- Reviewers
Mengerian deadalnix freetrader - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGINGe2fbf9721cc4: Update developer notes to include Arcanist setup instructions
rABCe2fbf9721cc4: Update developer notes to include Arcanist setup instructions
N/A
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- docs
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 1157 Build 1157: arc lint + arc unit
Event Timeline
Comment Actions
arcanist is included in the debian and ubuntu repositories no need to install it manually.
Comment Actions
Arc land was failing, and it seems the parent of the second diff didn't match what was in Differential for some reason. I've squashed my changes together and will try submitting those after a new approval...
Comment Actions
Looks good.
Reading though doc/developer-notes.md I can see we need to massively re-write it for Bitcoin ABC development.
We should include things like:
- General development philosophy and expectations (rapidly-iterating development process)
- How to get set-up with Phabricator
- More details on how to work with git and arcanist
But for now, this is a good start.