Differential D6560

[backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality into CWallet
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 21:40.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCcbe04c002b03: [backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality…

Summary

Instead of having a separate CCryptoKeyStore that handles the encryption
stuff, just roll it all into CWallet.

https://github.com/bitcoin/bitcoin/pull/16227/commits/8f5b81e6edae9cb22559545de63f391d97c15701

Depends on D6558

Partial backport of Core PR16227

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16227

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11462
Build 21999: Default Diff Build & Tests	Link to the build
Build 21998: Build without Wallet	Link to the build
Build 21997: Build with clang-10	Link to the build
Build 21996: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 12 2020, 21:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 21:41

majcosta requested review of this revision.Jun 12 2020, 21:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Jun 12 2020, 21:45

This revision is now accepted and ready to land.Jun 12 2020, 21:45

Harbormaster completed remote builds in B11462: Diff 21346.Jun 12 2020, 21:53

majcosta added a child revision: D6561: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.Jun 12 2020, 22:28

Closed by commit rABCcbe04c002b03: [backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 13 2020, 20:16

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCcbe04c002b03: [backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality….

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.cpp

2 lines

wallet/

62 lines

204 lines

52 lines

205 lines

Diff 21346

View Options

src/interfaces/wallet.cpp

View Options

src/wallet/crypter.h

View Options

src/wallet/crypter.cpp

View Options

src/wallet/wallet.h

View Options

[backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality into CWalletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21346

src/interfaces/wallet.cpp

src/wallet/crypter.h

src/wallet/crypter.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality into CWallet
ClosedPublic
Actions

Revision Contents
Changeset List