Page MenuHomePhabricator
Differential D706

Use GetConfig instead of GlobalConfig
AbandonedPublic
Actions

Authored by dagurval on Nov 16 2017, 12:43.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Summary

Bugfix: Use existing global config object instead of creating a new one.

Depends on D552

Test Plan

manual

Diff Detail

Repository
rABC Bitcoin ABC
Branch
16-11-cfgfix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1153
Build 1153: arc lint + arc unit

Event Timeline

dagurval created this revision.Nov 16 2017, 12:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 12:43
schancel accepted this revision.Nov 16 2017, 16:28
This revision is now accepted and ready to land.Nov 16 2017, 16:28
deadalnix requested changes to this revision.Nov 16 2017, 19:05
deadalnix added a subscriber: deadalnix.

Please do not commit a bogus patch and then fix it. Just do the right thing, especially if it is one liner.

This revision now requires changes to proceed.Nov 16 2017, 19:05
schancel requested changes to this revision.Nov 16 2017, 20:40

Didn't realize this was amending another diff that hadn't landed yet.

dagurval added a comment.Nov 16 2017, 22:08

You want me to un-land the bogus patch and fix it?

dagurval abandoned this revision.Nov 27 2017, 07:39

Bundled into D552

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 1797

View Options

src/qt/guiutil.cpp

Loading...