ran qt client
Details
Details
- Reviewers
deadalnix schancel - Group Reviewers
Restricted Project - Commits
- rSTAGINGa4afdad25f8f: Make Config more available in Qt
rABCa4afdad25f8f: Make Config more available in Qt
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- 23-11-configaround
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1250 Build 1250: arc lint + arc unit
Event Timeline
Comment Actions
I like the idea, please just make sure you use a pointer when you take ownership of the Config object down the road.
| src/qt/bitcoin.cpp | ||
|---|---|---|
| 219 ↗ | (On Diff #1816) | pointer |
| 367 ↗ | (On Diff #1816) | Pointer |
| src/qt/bitcoingui.h | ||
| 55 ↗ | (On Diff #1816) | because you take ownership, you shouldn't use a reference. Using reference usually imply you won't take ownership of things (it's not a hard rule, more like a common convention). |
| 134 ↗ | (On Diff #1816) | Pointer |
| src/qt/bitcoingui.h | ||
|---|---|---|
| 55 ↗ | (On Diff #1816) | I'm not taking ownership |
| src/qt/bitcoingui.h | ||
|---|---|---|
| 55 ↗ | (On Diff #1816) | You are keeping a reference to it. |