Page MenuHomePhabricator
Differential D710

Do not require NODE_BITCOIN_CASH (fix IBD)
ClosedPublic
Actions

Authored by freetrader on Nov 23 2017, 21:11.

Details

Reviewers
deadalnix
schancel
kyuupichan
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGINGb8923939fe05: Do not require NODE_BITCOIN_CASH (fix IBD)
rABCb8923939fe05: Do not require NODE_BITCOIN_CASH (fix IBD)
Summary

IBD was stuck after 'dnsseed thread exit',
broken by D669 as found by bisection.

This commit removes NODE_BITCOIN_CASH from REQUIRED_SERVICES
so that nodes without it can become connected.

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended
clear datadir, run IBD to completion

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_d669_ibd_stuck_at_beginning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1161
Build 1161: arc lint + arc unit

Event Timeline

freetrader created this revision.Nov 23 2017, 21:11
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptNov 23 2017, 21:11
deadalnix accepted this revision.Nov 23 2017, 21:21
This revision is now accepted and ready to land.Nov 23 2017, 21:21
Closed by commit rABCb8923939fe05: Do not require NODE_BITCOIN_CASH (fix IBD) (authored by freetrader). · Explain WhyNov 23 2017, 21:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 1818

View Options

src/net.h

Loading...