Page MenuHomePhabricator

Move mapBlockIndex to chain.h
ClosedPublic

Authored by deadalnix on Nov 25 2017, 01:39.

Details

Summary

And use the opportunity to cleanup checkpoints.cpp in the process.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkpoint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1163
Build 1163: arc lint + arc unit

Event Timeline

Did you forget to move the definition of mapBlockIndex from validation.cpp, or is this on purpose? You only moved the declaration in the header file. May also want to add a comment about it being protected by cs_main

It's on purpose, it ensure global are still initialized in the right order.

This revision is now accepted and ready to land.Nov 27 2017, 02:17
This revision was automatically updated to reflect the committed changes.