Add a test for ABC-specific getblocktemplate behavior
ClosedPublic
Actions

Authored by jasonbcox on Aug 20 2020, 20:41.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rABCf02132a0d60b: Add a test for ABC-specific getblocktemplate behavior

Summary

First step in T1014

As we modify behavior in getblocktemplate, we really need better test coverage.
D7201 (f8360b5e981) is one such change. This patch tests that behavior specifically
but this test can be expanded to cover other changes that we may have made or will
make in the future.

Test Plan

Before D7201, this test should fail

git checkout f8360b5e981^
git cherry-pick this-patch
test_runner.py abc_mining_basic

But the test passes today:

git checkout this-patch
test_runner.py abc_mining_basic
test_runner.py --with-axionactivation abc_mining_basic

Diff Detail

Repository

rABC Bitcoin ABC

Branch

abc-mining-basic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12450
Build 25061: Build Diff	build-clang-tidy · build-clang-10 · build-diff · build-without-wallet
Build 25060: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 20 2020, 20:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2020, 20:41

jasonbcox requested review of this revision.Aug 20 2020, 20:41

Harbormaster completed remote builds in B12438: Diff 22987.Aug 20 2020, 20:57

jasonbcox planned changes to this revision.Aug 20 2020, 22:15

Make the test more friendly to future additions

jasonbcox added a child revision: D7233: Add test coverage for getblocktemplate's mintime.Aug 20 2020, 22:37

Harbormaster completed remote builds in B12442: Diff 22994.Aug 20 2020, 22:42

Fabien requested changes to this revision.Aug 21 2020, 06:29

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/abc_mining_basic.py
58 ↗	(On Diff #22994)	This assumes there is no transaction nor halving occurring. Either put a comment to state that the block reward from getblocktemplate is not related to the one from the current tip, or find a more accurate way to express the constraint you want to test.
66 ↗	(On Diff #22994)	`> 1` is more accurate
73 ↗	(On Diff #22994)	Dito