Differential D7314

[CMAKE] Add an install target for the secp256k1 benchmarks
ClosedPublic
Actions

Authored by Fabien on Sep 2 2020, 16:31.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC23318e6f69ec: [CMAKE] Add an install target for the secp256k1 benchmarks

Summary

The secp256k1 benchmarks are missing an installation target.

Test Plan

ninja install-secp256k1-bench

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_install_sepc256k1_bench

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12554
Build 25226: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25225: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 2 2020, 16:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2020, 16:31

Fabien requested review of this revision.Sep 2 2020, 16:31

Harbormaster completed remote builds in B12554: Diff 23178.Sep 2 2020, 16:55

Missing exclude from all

Exclude the install target from the default installation

Harbormaster completed remote builds in B12559: Diff 23187.Sep 2 2020, 19:22

Fabien added a child revision: D7324: [CI] Allow for describing the build from the configuration file.Sep 2 2020, 20:03

jasonbcox accepted this revision.Sep 2 2020, 22:29

This revision is now accepted and ready to land.Sep 2 2020, 22:29

Closed by commit rABC23318e6f69ec: [CMAKE] Add an install target for the secp256k1 benchmarks (authored by Fabien). · Explain WhySep 3 2020, 08:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC23318e6f69ec: [CMAKE] Add an install target for the secp256k1 benchmarks.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

CMakeLists.txt

6 lines

Diff 23178

View Options

src/secp256k1/CMakeLists.txt

[CMAKE] Add an install target for the secp256k1 benchmarksClosedPublicActions