Paths

Table of Contentst

Clarify source control tools cmake flag
ClosedPublic
Actions

Authored by jasonbcox on Sep 4 2020, 16:26.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rABC6e00a2676796: Clarify source control tools cmake flag

Summary

Rename the flag since enabling it builds no source code, it only enables
a test suite.

Depends on D7353

Test Plan

./build-configurations.py check-source-control-tools

Diff Detail

Repository

rABC Bitcoin ABC

Branch

test-sct

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12649
Build 25399: Build Diff	build-clang-tidy · build-diff · build-clang-10 · build-without-wallet
Build 25398: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 4 2020, 16:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2020, 16:26

jasonbcox requested review of this revision.Sep 4 2020, 16:26

Harbormaster completed remote builds in B12622: Diff 23297.Sep 4 2020, 16:49

This is not building, but this is not testing either. What about ENABLE_SOURCE_CONTROL_TOOLS_TESTS ?

This revision now requires changes to proceed.Sep 4 2020, 19:38

In D7363#175807, @Fabien wrote:

This is not building, but this is not testing either. What about ENABLE_SOURCE_CONTROL_TOOLS_TESTS ?

This is better. I had initially rejected ENABLE_SOURCE_CONTROL_TOOLS since it does not enable the tools but didn't continue that line of thought.

Rebase
Update naming per feedback

Harbormaster completed remote builds in B12641: Diff 23331.Sep 5 2020, 00:26

deadalnix accepted this revision.Sep 5 2020, 12:26

Fabien accepted this revision.Sep 7 2020, 06:33

Fabien added inline comments.

contrib/CMakeLists.txt
1 ↗	(On Diff #23331)	Can can also update the description the same way

This revision is now accepted and ready to land.Sep 7 2020, 06:33

Fix description

Harbormaster completed remote builds in B12649: Diff 23347.Sep 7 2020, 16:59

Closed by commit rABC6e00a2676796: Clarify source control tools cmake flag (authored by jasonbcox). · Explain WhySep 7 2020, 18:51

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC6e00a2676796: Clarify source control tools cmake flag.

Revision Contents
Changeset List

Path

Size

contrib/

CMakeLists.txt

4 lines

teamcity/

build-configurations.yml

2 lines

Diff 23347

View Options

contrib/CMakeLists.txt