Page MenuHomePhabricator

Clarify source control tools cmake flag
ClosedPublic

Authored by jasonbcox on Sep 4 2020, 16:26.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6e00a2676796: Clarify source control tools cmake flag
Summary

Rename the flag since enabling it builds no source code, it only enables
a test suite.

Depends on D7353

Test Plan
./build-configurations.py check-source-control-tools

Diff Detail

Event Timeline

Fabien requested changes to this revision.Sep 4 2020, 19:38
Fabien added a subscriber: Fabien.

This is not building, but this is not testing either. What about ENABLE_SOURCE_CONTROL_TOOLS_TESTS ?

This revision now requires changes to proceed.Sep 4 2020, 19:38

This is not building, but this is not testing either. What about ENABLE_SOURCE_CONTROL_TOOLS_TESTS ?

This is better. I had initially rejected ENABLE_SOURCE_CONTROL_TOOLS since it does not enable the tools but didn't continue that line of thought.

  • Rebase
  • Update naming per feedback
Fabien added inline comments.
contrib/CMakeLists.txt
1 ↗(On Diff #23331)

Can can also update the description the same way

This revision is now accepted and ready to land.Sep 7 2020, 06:33
This revision was automatically updated to reflect the committed changes.