Page MenuHomePhabricator

[CI] Add an option to select the generator
ClosedPublic

Authored by Fabien on Sep 8 2020, 15:54.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC6e750b82fd45: [CI] Add an option to select the generator
Summary

This let the builds run with another generator instead of ninja.
make is special cased to include the -jN+1 option with N being the
CPU count.

Test Plan
./build-configurations.py build-make-generator

Diff Detail

Event Timeline

Fabien requested review of this revision.Sep 8 2020, 15:54
Fabien updated this revision to Diff 23378.

Remove the script

Fabien edited the summary of this revision. (Show Details)

Rebase

jasonbcox requested changes to this revision.Sep 8 2020, 20:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.py
231 ↗(On Diff #23387)

remove

239 ↗(On Diff #23387)

remove

This revision now requires changes to proceed.Sep 8 2020, 20:31
contrib/teamcity/build-configurations.yml
218 ↗(On Diff #23387)

does this not need quotes?

contrib/teamcity/build-configurations.yml
218 ↗(On Diff #23387)

I don't think it's necessary because it's not a list (and it works), but I can add them for sanity

Remove obsolete comments, add quotes

This revision is now accepted and ready to land.Sep 8 2020, 20:39
This revision was automatically updated to reflect the committed changes.