Page MenuHomePhabricator
Differential D7397

[CI] Add an option to select the generator
ClosedPublic
Actions

Authored by Fabien on Sep 8 2020, 15:54.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC6e750b82fd45: [CI] Add an option to select the generator
Summary

This let the builds run with another generator instead of ninja.
make is special cased to include the -jN+1 option with N being the
CPU count.

Test Plan
./build-configurations.py build-make-generator

Diff Detail

Event Timeline

Fabien created this revision.Sep 8 2020, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2020, 15:54
Fabien requested review of this revision.Sep 8 2020, 15:54
Fabien updated this revision to Diff 23378.

Remove the script

Harbormaster completed remote builds in B12666: Diff 23377.Sep 8 2020, 16:12
Harbormaster completed remote builds in B12667: Diff 23378.Sep 8 2020, 16:15
Fabien added a child revision: D7403: [CI] Allow to configure a post build script.Sep 8 2020, 20:13
Fabien edited the summary of this revision. (Show Details)Sep 8 2020, 20:25
Fabien updated this revision to Diff 23387.Sep 8 2020, 20:26
Fabien edited the summary of this revision. (Show Details)

Rebase

Fabien removed a parent revision: D7392: [CI] Move the environment variables to the configuration object.Sep 8 2020, 20:27
Fabien edited the summary of this revision. (Show Details)
jasonbcox requested changes to this revision.Sep 8 2020, 20:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build-configurations.py
231 ↗(On Diff #23387)

remove

239 ↗(On Diff #23387)

remove

This revision now requires changes to proceed.Sep 8 2020, 20:31
jasonbcox added inline comments.Sep 8 2020, 20:32
contrib/teamcity/build-configurations.yml
218 ↗(On Diff #23387)

does this not need quotes?

Fabien added inline comments.Sep 8 2020, 20:34
contrib/teamcity/build-configurations.yml
218 ↗(On Diff #23387)

I don't think it's necessary because it's not a list (and it works), but I can add them for sanity

Fabien updated this revision to Diff 23389.Sep 8 2020, 20:35

Remove obsolete comments, add quotes

jasonbcox accepted this revision.Sep 8 2020, 20:39
This revision is now accepted and ready to land.Sep 8 2020, 20:39
Harbormaster completed remote builds in B12674: Diff 23387.Sep 8 2020, 21:12
Harbormaster completed remote builds in B12676: Diff 23389.Sep 8 2020, 21:19
Closed by commit rABC6e750b82fd45: [CI] Add an option to select the generator (authored by Fabien). · Explain WhySep 9 2020, 06:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6e750b82fd45: [CI] Add an option to select the generator.
Fabien removed a child revision: D7403: [CI] Allow to configure a post build script.Sep 9 2020, 10:30

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
20 lines
8 lines
builds/

Diff 23378

View Options

contrib/teamcity/build-configurations.py

Loading...
View Options

contrib/teamcity/build-configurations.yml

Loading...
View Options

contrib/teamcity/builds/build-make-generator.sh

Loading...