Differential D7508

[backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization list
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 01:53.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa49534be0208: [backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization…

Summary

https://github.com/bitcoin/bitcoin/pull/15931/commits/9700fcb47feca9d78e005b8d18b41148c8f6b25f

Depends on D7507

Partial backport of Core PR15931

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12838
Build 25746: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25745: arc lint + arc unit

Event Timeline

majcosta created this revision.Sep 22 2020, 01:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 01:53

majcosta requested review of this revision.Sep 22 2020, 01:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12838: Diff 23649.Sep 22 2020, 02:06

majcosta added a child revision: D7509: [backport#15931 4/9] Add block_height field in struct Confirmation.Sep 22 2020, 02:15

Fabien accepted this revision.Sep 22 2020, 06:03

This revision is now accepted and ready to land.Sep 22 2020, 06:03

Closed by commit rABCa49534be0208: [backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 14:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa49534be0208: [backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization….

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

5 lines

test/

wallet_tests.cpp

15 lines

wallet.h

20 lines

wallet.cpp

54 lines

Diff 23649

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/wallet.h

View Options

[backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization listClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23649

src/wallet/rpcdump.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization list
ClosedPublic
Actions

Revision Contents
Changeset List