Page MenuHomePhabricator

[CI] run ThreadSanitizer builds with clang-10
ClosedPublic

Authored by majcosta on Sep 24 2020, 22:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC62ff86f8243b: [CI] run ThreadSanitizer builds with clang-10
Summary

My CI VM is consistently green with the latest BerkleyBatch suppression PR, looks like a good time to bump this up.

Depends on D7560

Test Plan

on a fresh VM of our CI:

build-configuration.py build-tsan

ran three times in a row all green.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested changes to this revision.Sep 25 2020, 07:39
Fabien added a subscriber: Fabien.

Since all the sanitizers now pass with clang-10, we should rather make clang-10 the default.

This revision now requires changes to proceed.Sep 25 2020, 07:39

migrated every clang build to clang-10

Snippet of first build failure:

[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Counting objects: 100% (19/19), done.        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:   9% (1/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  18% (2/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  27% (3/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  36% (4/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  45% (5/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  54% (6/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  63% (7/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  72% (8/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  81% (9/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects:  90% (10/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects: 100% (11/11)        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Compressing objects: 100% (11/11), done.        
[17:07:47]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] remote: Total 11 (delta 8), reused 0 (delta 0), pack-reused 0        
[17:07:48]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[17:07:48]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801]  * [new tag]             phabricator/diff/23801 -> phabricator/diff/23801
[17:07:48]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23801:refs/tags/phabricator/diff/23801]  * [new tag]             phabricator/base/23801 -> phabricator/base/23801
[17:07:48] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 55015bb9c268c5cfa84ff797be9f2c770b99e05f --
[17:07:48] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[17:07:48] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23801
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 55015bb9c268c5cfa84ff797be9f2c770b99e05f --
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/23801
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23801
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[17:07:48] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[17:07:48] : Build preparation done
[17:07:48]E: Step 1/1: Command Line (7m:24s)
[17:07:48] :	 [Step 1/1] Ant JUnit report watcher
[17:07:48] :		 [Ant JUnit report watcher] Watching paths:
[17:07:48] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[17:07:48] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[17:07:48] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script8156966817254888904
[17:07:48] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[17:07:48] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[17:07:48] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[17:07:48] :	 [Step 1/1] Building base image for: 55015bb9c...
[17:07:48] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[17:07:49] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[17:07:49] :	 [Step 1/1] Tag name: abc-base-image-55015bb9c
[17:15:09]W:	 [Step 1/1] Traceback (most recent call last):
[17:15:09]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 556, in <module>
[17:15:09]W:	 [Step 1/1]     main()
[17:15:09]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 545, in main
[17:15:09]W:	 [Step 1/1]     script_dir, config_path, args.build)
[17:15:09]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 59, in __init__
[17:15:09]W:	 [Step 1/1]     self.load(build_name)
[17:15:09]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 82, in load
[17:15:09]W:	 [Step 1/1]     self.name, list(config.keys())
[17:15:09]W:	 [Step 1/1] AssertionError: build-clang-10 is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[17:15:09]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[17:15:09]W:	 [Step 1/1] Try 'mv --help' for more information.
[17:15:12]W:	 [Step 1/1] Process exited with code 1
[17:15:12]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)

make changes to the setup-buster script rather than the build script

change name of diff build from clang-build-10 to clang-build

This revision is now accepted and ready to land.Fri, Sep 25, 19:56

Snippet of first build failure:

[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Counting objects:  72% (8/11)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Counting objects:  81% (9/11)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Counting objects:  90% (10/11)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Counting objects: 100% (11/11)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Counting objects: 100% (11/11), done.        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects:  16% (1/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects:  33% (2/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects:  50% (3/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects:  66% (4/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects:  83% (5/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects: 100% (6/6)        
[19:51:56]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Compressing objects: 100% (6/6), done.        
[19:51:57]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] remote: Total 6 (delta 5), reused 0 (delta 0), pack-reused 0        
[19:51:57]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[19:51:57]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814]  * [new tag]             phabricator/diff/23814 -> phabricator/diff/23814
[19:51:57]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814]  * [new tag]             phabricator/base/23813 -> phabricator/base/23813
[19:51:57]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/23814:refs/tags/phabricator/diff/23814]  * [new tag]             phabricator/base/23814 -> phabricator/base/23814
[19:51:57] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s c988727070322a62c678f6abdfea85f30c761825 --
[19:51:57] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[19:51:57] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23814
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s c988727070322a62c678f6abdfea85f30c761825 --
[19:51:57] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/23814
[19:51:58] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/23814
[19:51:58] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[19:51:58] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[19:51:58] : Build preparation done
[19:51:58]E: Step 1/1: Command Line (9m:37s)
[19:51:58] :	 [Step 1/1] Ant JUnit report watcher
[19:51:58] :		 [Ant JUnit report watcher] Watching paths:
[19:51:58] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[19:51:58] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[19:51:58] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script4213287252604126336
[19:51:58] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/jailed-build
[19:51:58] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:51:58] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[19:51:58] :	 [Step 1/1] Building base image for: c98872707...
[19:51:58] :	 [Step 1/1] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:51:59] :	 [Step 1/1] ~/buildAgent/work/jailed-build
[19:51:59] :	 [Step 1/1] Tag name: abc-base-image-c98872707
[20:01:31]W:	 [Step 1/1] Traceback (most recent call last):
[20:01:31]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 556, in <module>
[20:01:31]W:	 [Step 1/1]     main()
[20:01:31]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 545, in main
[20:01:31]W:	 [Step 1/1]     script_dir, config_path, args.build)
[20:01:31]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 59, in __init__
[20:01:31]W:	 [Step 1/1]     self.load(build_name)
[20:01:31]W:	 [Step 1/1]   File "./contrib/teamcity/build-configurations.py", line 82, in load
[20:01:31]W:	 [Step 1/1]     self.name, list(config.keys())
[20:01:31]W:	 [Step 1/1] AssertionError: build-clang-10 is not a valid build identifier. Valid identifiers are ['templates', 'builds']
[20:01:31]W:	 [Step 1/1] mv: missing destination file operand after '/results'
[20:01:31]W:	 [Step 1/1] Try 'mv --help' for more information.
[20:01:35]W:	 [Step 1/1] Process exited with code 1
[20:01:35]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
This revision was landed with ongoing or failed builds.Fri, Sep 25, 20:55
This revision was automatically updated to reflect the committed changes.