Fix cashaddrenc_tests/check_size
ClosedPublic
Actions

Authored by schancel on Dec 6 2017, 04:20.

Details

Reviewers

deadalnix
dagurval
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGINGd9b1cd518eab: Fix cashaddrenc_tests/check_size
rABCd9b1cd518eab: Fix cashaddrenc_tests/check_size

Summary

Fix the construction logic for check_size test.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_check_size

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1263
Build 1263: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 6 2017, 04:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2017, 04:20

Harbormaster completed remote builds in B1260: Diff 1957.Dec 6 2017, 04:20

Not clear to me why adding 1.5 bytes with no comment is desirable. I thought initially the 12 was due to the bitcoincash prefix somehow.

I don't think the logic is broken to begin with and I don't think adding floating point ops is beneficial. If anything it opens to rounding problems.

This revision now requires changes to proceed.Dec 6 2017, 12:57

If I had to spend 30 minutes trying to figure out why expectedSize was calculated the way it is, then the comment is valuable.

Remove floating point math

Rebase

Harbormaster completed remote builds in B1264: Diff 1962.Dec 6 2017, 16:23

deadalnix accepted this revision.Dec 6 2017, 16:26

This revision is now accepted and ready to land.Dec 6 2017, 16:26

Closed by commit rABCd9b1cd518eab: Fix cashaddrenc_tests/check_size (authored by schancel). · Explain WhyDec 6 2017, 16:38

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

cashaddrenc_tests.cpp

7 lines

Diff 1961

View Options

src/test/cashaddrenc_tests.cpp

Fix cashaddrenc_tests/check_sizeClosedPublicActions