Page MenuHomePhabricator

wallet: Avoid use of Chain::Lock in rescanblockchain
ClosedPublic

Authored by deadalnix on Sat, Oct 10, 23:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC695fa2f2d696: wallet: Avoid use of Chain::Lock in rescanblockchain
Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change only affects behavior in the case where wallet last block processed
falls behind the chain tip. The rescanblockchain error height error checking
will just be stricter in this case and only accept values up to the last
processed height

This is part [9/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/1be8ff280c78c30baabae9429c53c0bebb89c44d

Depends on D7871

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.