Differential D7874

wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC08a6658f7f5a: wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction

Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change only affects behavior in the case where wallet last block processed
falls behind the chain tip, where it may set a different lock time.

This is part [11/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/e958ff9ab5607da2cd321f29fc785a6d359e44f4

Depends on D7873

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:56

deadalnix requested review of this revision.Oct 10 2020, 23:56

teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:56

deadalnix added a child revision: D7875: wallet: Avoid use of Chain::Lock in CWallet::GetKeyBirthTimes.Oct 10 2020, 23:57

Harbormaster completed remote builds in B13345: Diff 24522.Oct 11 2020, 00:09

Fabien accepted this revision.Oct 11 2020, 11:11

This revision is now accepted and ready to land.Oct 11 2020, 11:11

Closed by commit rABC08a6658f7f5a: wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 11 2020, 12:42

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC08a6658f7f5a: wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

24 lines

Diff 24542

View Options

wallet: Avoid use of Chain::Lock in CWallet::CreateTransactionClosedPublicActions