This change gets rid of -Wthread-safety-attributes warning spam.
This is part [3/5] of Core PR18635 : https://github.com/bitcoin/bitcoin/pull/18635/commits/971a468ccf0474ca00fa7d20278569b8fb11f0fb
Depends on D7878
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCde6770e8a3bc: Use template function instead of void* parameter
ninja all check
Checks that clang thread safety analysis is happy.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Snippet of first build failure:
[344/405] Running utility command for check-bitcoin-bip32_tests [345/405] Running utility command for check-bitcoin-wallet_crypto_tests [346/405] Running utility command for check-bitcoin-sync_tests [347/405] bitcoin: testing torcontrol_tests [348/405] Running utility command for check-bitcoin-torcontrol_tests [349/405] bitcoin: testing settings_tests [350/405] bitcoin: testing timedata_tests [351/405] bitcoin: testing streams_tests [352/405] Running utility command for check-bitcoin-settings_tests [353/405] Running utility command for check-bitcoin-timedata_tests [354/405] Running utility command for check-bitcoin-streams_tests [355/405] bitcoin: testing uint256_tests [356/405] Running utility command for check-bitcoin-uint256_tests [357/405] bitcoin: testing undo_tests [358/405] bitcoin: testing util_threadnames_tests [359/405] Running utility command for check-bitcoin-undo_tests [360/405] Running utility command for check-bitcoin-util_threadnames_tests [361/405] bitcoin: testing walletdb_tests [362/405] Running utility command for check-bitcoin-walletdb_tests [363/405] bitcoin: testing serialize_tests [364/405] bitcoin: testing validationinterface_tests [365/405] bitcoin: testing checkpoints_tests [366/405] Running utility command for check-bitcoin-serialize_tests [367/405] Running utility command for check-bitcoin-validationinterface_tests [368/405] bitcoin: testing txvalidationcache_tests [369/405] Running utility command for check-bitcoin-checkpoints_tests [370/405] Running utility command for check-bitcoin-txvalidationcache_tests [371/405] bitcoin: testing radix_tests [372/405] Running utility command for check-bitcoin-radix_tests [373/405] bitcoin: testing script_standard_tests [374/405] Running utility command for check-bitcoin-script_standard_tests [375/405] bitcoin: testing blockstatus_tests [376/405] bitcoin: testing crypto_tests [377/405] bitcoin: testing blockcheck_tests [378/405] Running utility command for check-bitcoin-crypto_tests [379/405] Running utility command for check-bitcoin-blockstatus_tests [380/405] Running utility command for check-bitcoin-blockcheck_tests [381/405] bitcoin: testing ismine_tests [382/405] Running utility command for check-bitcoin-ismine_tests [383/405] bitcoin: testing versionbits_tests [384/405] Running utility command for check-bitcoin-versionbits_tests [385/405] bitcoin: testing cashaddr_tests [386/405] Running utility command for check-bitcoin-cashaddr_tests [387/405] bitcoin: testing validation_tests [388/405] bitcoin: testing script_tests [389/405] Running utility command for check-bitcoin-validation_tests [390/405] Running utility command for check-bitcoin-script_tests [391/405] bitcoin: testing cuckoocache_tests [392/405] Running utility command for check-bitcoin-cuckoocache_tests [393/405] bitcoin: testing validation_block_tests [394/405] Running utility command for check-bitcoin-validation_block_tests [395/405] bitcoin: testing skiplist_tests [396/405] Running utility command for check-bitcoin-skiplist_tests [397/405] bitcoin: testing transaction_tests [398/405] Running utility command for check-bitcoin-transaction_tests [399/405] bitcoin: testing util_tests [400/405] Running utility command for check-bitcoin-util_tests [401/405] bitcoin: testing coins_tests [402/405] Running utility command for check-bitcoin-coins_tests Build build-clang-tidy timed out after 1800.0s