Page MenuHomePhabricator
Differential D7873

wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf4fe76343ac5: wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions
Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change affects behavior in a few small ways.

  • If there's no max_height specified, percentage progress is measured ending at wallet last processed block instead of node tip
  • More consistent error reporting: Early check to see if start_block is on the active chain is removed, so start_block is always read and the triggers an error if it's unavailable

This is part [10/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/c0d07dc4cba7634cde4e8bf586557772f3248a42

Depends on D7872

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:50
deadalnix requested review of this revision.Oct 10 2020, 23:50
teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:50
deadalnix edited the summary of this revision. (Show Details)Oct 10 2020, 23:51
deadalnix added a child revision: D7874: wallet: Avoid use of Chain::Lock in CWallet::CreateTransaction.Oct 10 2020, 23:56
Harbormaster completed remote builds in B13344: Diff 24521.Oct 11 2020, 00:02
Fabien accepted this revision.Oct 11 2020, 11:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
1773 ↗(On Diff #24521)

Undo

This revision is now accepted and ready to land.Oct 11 2020, 11:09
deadalnix updated this revision to Diff 24540.Oct 11 2020, 12:36

reflow comment

This revision was landed with ongoing or failed builds.Oct 11 2020, 12:39
Closed by commit rABCf4fe76343ac5: wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf4fe76343ac5: wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions.
Harbormaster completed remote builds in B13353: Diff 24540.Oct 11 2020, 13:13

Revision Contents
Changeset List

PathSize
src/
interfaces/
7 lines
13 lines
qt/
test/
4 lines
test/
16 lines
wallet/
2 lines
test/
23 lines
3 lines
89 lines

Diff 24541

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/test/interfaces_tests.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...