Page MenuHomePhabricator

wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions
ClosedPublic

Authored by deadalnix on Sat, Oct 10, 23:50.

Details

Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

This change affects behavior in a few small ways.

  • If there's no max_height specified, percentage progress is measured ending at wallet last processed block instead of node tip
  • More consistent error reporting: Early check to see if start_block is on the active chain is removed, so start_block is always read and the triggers an error if it's unavailable

This is part [10/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/c0d07dc4cba7634cde4e8bf586557772f3248a42

Depends on D7872

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/wallet.cpp
1773 ↗(On Diff #24521)

Undo

This revision is now accepted and ready to land.Sun, Oct 11, 11:09
This revision was landed with ongoing or failed builds.Sun, Oct 11, 12:39
This revision was automatically updated to reflect the committed changes.