Page MenuHomePhabricator

wallet: Avoid use of Chain::Lock in CWallet::ScanForWalletTransactions

Authored by deadalnix on Oct 10 2020, 23:50.



This is a step toward removing the Chain::Lock class and reducing cs_main

This change affects behavior in a few small ways.

  • If there's no max_height specified, percentage progress is measured ending at wallet last processed block instead of node tip
  • More consistent error reporting: Early check to see if start_block is on the active chain is removed, so start_block is always read and the triggers an error if it's unavailable

This is part [10/12] of Core PR17954 :

Depends on D7872

Test Plan
ninja all check-all

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
1773 ↗(On Diff #24521)


This revision is now accepted and ready to land.Oct 11 2020, 11:09
This revision was landed with ongoing or failed builds.Oct 11 2020, 12:39
This revision was automatically updated to reflect the committed changes.