Differential D7936

[wallet] Move getBlockHash from Chain::Lock interface to simple Chain
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 14:49.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC890765dfd7ee: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain

Summary

Backport of Core PR16426 part [3/5] : https://github.com/bitcoin/bitcoin/pull/16426/commits/0a76287387950bc9c5b634e95c5cd5fb1029f42d

Depends on D7935

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16426-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13419
Build 26872: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26871: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 15 2020, 14:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 14:49

deadalnix requested review of this revision.Oct 15 2020, 14:49

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 14:49

deadalnix added a child revision: D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.Oct 15 2020, 14:51

Harbormaster completed remote builds in B13419: Diff 24661.Oct 15 2020, 15:04

majcosta accepted this revision.Oct 15 2020, 15:29

This revision is now accepted and ready to land.Oct 15 2020, 15:29

Closed by commit rABC890765dfd7ee: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>, committed by deadalnix). · Explain WhyOct 15 2020, 21:28

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC890765dfd7ee: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.h

6 lines

chain.cpp

12 lines

wallet/

wallet.cpp

7 lines

Diff 24661

View Options

src/interfaces/chain.h

View Options

src/interfaces/chain.cpp

View Options

[wallet] Move getBlockHash from Chain::Lock interface to simple ChainClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24661

src/interfaces/chain.h

src/interfaces/chain.cpp

src/wallet/wallet.cpp

[wallet] Move getBlockHash from Chain::Lock interface to simple Chain
ClosedPublic
Actions

Revision Contents
Changeset List