Differential D8019

refactor: Get rid of Wallet::IsWalletFlagSet method
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2020, 13:20.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb4ad0581f635: refactor: Get rid of Wallet::IsWalletFlagSet method

Summary

Replace by privateKeysDisabled method to avoid need for GUI to reference
internal wallet flags.

Also remove adjacent WalletModel canGetAddresses wrapper that serves no purpose
and make Wallet::canGetAddresses non-const so it can be implemented by IPC
classes in #10102.

Backport of Core PR18278 part [1/6] : https://github.com/bitcoin/bitcoin/pull/18278/commits/77e4b0657298c715c835d8d2eb11e173852e6815

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 21 2020, 13:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 13:20

deadalnix requested review of this revision.Oct 21 2020, 13:20

teamcity edited the summary of this revision. (Show Details)Oct 21 2020, 13:21

deadalnix added a child revision: D8020: refactor: Rename Node::disconnect methods.Oct 21 2020, 13:23

Harbormaster completed remote builds in B13554: Diff 24883.Oct 21 2020, 13:32

Fabien accepted this revision.Oct 21 2020, 13:47

This revision is now accepted and ready to land.Oct 21 2020, 13:47

Closed by commit rABCb4ad0581f635: refactor: Get rid of Wallet::IsWalletFlagSet method (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 21 2020, 14:29

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb4ad0581f635: refactor: Get rid of Wallet::IsWalletFlagSet method.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.h

4 lines

wallet.cpp

4 lines

qt/

bitcoingui.cpp

2 lines

overviewpage.cpp

13 lines

receivecoinsdialog.cpp

4 lines

sendcoinsdialog.cpp

16 lines

walletmodel.h

2 lines

walletmodel.cpp

16 lines

Diff 24891

View Options

src/interfaces/wallet.h

View Options

src/interfaces/wallet.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/walletmodel.h

View Options

refactor: Get rid of Wallet::IsWalletFlagSet methodClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24891

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/bitcoingui.cpp

src/qt/overviewpage.cpp

src/qt/receivecoinsdialog.cpp

src/qt/sendcoinsdialog.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

refactor: Get rid of Wallet::IsWalletFlagSet method
ClosedPublic
Actions

Revision Contents
Changeset List