Refactor: split network transport deserializing from message container
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:29.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC360f3ded8bb2: Refactor: split network transport deserializing from message container

Summary

Partial backport 1/7 of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/6294ecdb8bb4eb7049a18c721ee8cb4a53d80a06

Adapted to match our codebase.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16202_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13802
Build 27623: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-clang · build-debug
Build 27622: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2020, 21:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:29

Fabien requested review of this revision.Nov 1 2020, 21:29

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:30

Fabien added a child revision: D8223: Remove transport protocol knowhow from CNetMessage / net processing.Nov 1 2020, 21:35

Harbormaster completed remote builds in B13802: Diff 25335.Nov 1 2020, 21:42

PiRK accepted this revision.Nov 2 2020, 07:46

This revision is now accepted and ready to land.Nov 2 2020, 07:46

Please be sure to land with the rest of the stack.

Closed by commit rABC360f3ded8bb2: Refactor: split network transport deserializing from message container (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyNov 3 2020, 10:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC360f3ded8bb2: Refactor: split network transport deserializing from message container.

Revision Contents
Changeset List

Path

Size

src/

net.h

45 lines

net.cpp

99 lines

net_processing.cpp

42 lines

test/

functional/

p2p_invalid_messages.py

2 lines

Diff 25335

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

test/functional/p2p_invalid_messages.py

Refactor: split network transport deserializing from message containerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25335

src/net.h

src/net.cpp

src/net_processing.cpp

test/functional/p2p_invalid_messages.py

Refactor: split network transport deserializing from message container
ClosedPublic
Actions

Revision Contents
Changeset List