Add override/final modifiers to V1TransportDeserializer
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:53.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC843cb6508702: Add override/final modifiers to V1TransportDeserializer

Summary

Completes backport (7/7) of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/ed2dc5e48abed1cde6ab98025dc8212917d47d21

Depends on D8227.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16202_part7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13808
Build 27635: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27634: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2020, 21:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:53

Fabien requested review of this revision.Nov 1 2020, 21:53

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:54

Fabien added a child revision: D8229: tests: Add fuzzing harness for V1TransportDeserializer (P2P transport).Nov 1 2020, 22:12

Harbormaster completed remote builds in B13808: Diff 25341.Nov 1 2020, 22:13

PiRK accepted this revision.Nov 2 2020, 08:54

This revision is now accepted and ready to land.Nov 2 2020, 08:54

jasonbcox accepted this revision.Nov 2 2020, 22:03

Closed by commit rABC843cb6508702: Add override/final modifiers to V1TransportDeserializer (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyNov 3 2020, 10:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC843cb6508702: Add override/final modifiers to V1TransportDeserializer.

Revision Contents
Changeset List

Path

Size

src/

net.h

10 lines

Diff 25341

View Options

Add override/final modifiers to V1TransportDeserializerClosedPublicActions