Page MenuHomePhabricator
Differential D8384

Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey
ClosedPublic
Actions

Authored by deadalnix on Nov 13 2020, 00:01.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC06534944000e: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and…
Summary

Have Expand, ExpandFromCache, and ExpandHelper take additional DescriptorCache
parameters. These are then passed into PubkeyProvider::GetPubKey which
also takes them as arguments.

Reading and writing to the cache is pushed down into GetPubKey. The old cache where
pubkeys are serialized to a vector is completely removed and instead xpubs are being
cached in DescriptorCache.

Backport of Core PR18204 part [4/7] : https://github.com/bitcoin/bitcoin/pull/18204/commits/58f54b686f663e4c46a2cf7a64560409007c7eb3

Depends on D8383

Test Plan
ninja all check

Diff Detail

Event Timeline

deadalnix created this revision.Nov 13 2020, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2020, 00:01
deadalnix requested review of this revision.Nov 13 2020, 00:01
teamcity edited the summary of this revision. (Show Details)Nov 13 2020, 00:02
Harbormaster completed remote builds in B14014: Diff 25698.Nov 13 2020, 00:18
deadalnix added a child revision: D8386: Cache the immediate derivation parent xpub.Nov 13 2020, 01:22
majcosta accepted this revision.Nov 13 2020, 04:46
This revision is now accepted and ready to land.Nov 13 2020, 04:46
majcosta requested changes to this revision.Nov 13 2020, 04:48

this is done out of order, rebase this on top of D8389

This revision now requires changes to proceed.Nov 13 2020, 04:48
majcosta accepted this revision.Nov 13 2020, 04:49

sry, actually not blocking

This revision is now accepted and ready to land.Nov 13 2020, 04:49
Closed by commit rABC06534944000e: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 13 2020, 13:28
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC06534944000e: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and….

Revision Contents
Changeset List

PathSize
src/
script/
35 lines
183 lines
test/
10 lines

Diff 25698

View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/descriptor_tests.cpp

Loading...