Add cashtab to web projects
Details
Details
- Reviewers
jasonbcox deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC8a531d5ceb50: Add cashtab to web projects
Run the app in your browser (will open in tab at localhost:3000):
cd web/cashtab
npm install
npm start
Run the unit tests:
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
1/ Let the linter do its job.
2/ npm i plain doesn't work.
| web/cashtab/.editorconfig | ||
|---|---|---|
| 20 ↗ | (On Diff #26044) | Prettier will deal with that. We also don't want to have project specific configs this way. |
| web/cashtab/.prettierrc | ||
| 7 ↗ | (On Diff #26044) | Remove |
| web/cashtab/.vscode/launch.json | ||
| 14 ↗ | (On Diff #26044) | We don't really support vscode, are you suing it yourself? If not then remove this. |
Comment Actions
Switch from yarn to npm, remove unneeded config files, remove pre-commit cashtab linting
| web/cashtab/package-lock.json | ||
|---|---|---|
| 1 ↗ | (On Diff #26048) | I'm getting massive changes in there from npm install. npm update is busted. |
Comment Actions
Specifying node and npm versions, updating readme, welcome msg revision from feedback
Comment Actions
Please don't start a project on outdated tech.
| web/cashtab/README.md | ||
|---|---|---|
| 20 ↗ | (On Diff #26053) | Why? This is what ship standard on most distros. Also, how is this going to work when we have several node projects in there and each require a specific version of node? |
Comment Actions
I can run the testplan on my Arch box.
On a debian buster machine running our CI script it fails a test and complains about Npm being <6. I can run the test plan after apt-get -t buster-backports install npm for 6.14.8 only.
Comment Actions
Shipping your arch box to every users do not seems like an appropriate alternative to fixing the test plan.