Page MenuHomePhabricator

Add cashtab to web projects
ClosedPublic

Authored by bytesofman on Nov 25 2020, 23:16.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8a531d5ceb50: Add cashtab to web projects
Summary

Add cashtab to web projects

Test Plan

Run the app in your browser (will open in tab at localhost:3000):
cd web/cashtab
npm install
npm start

Run the unit tests:
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D8530
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14221
Build 28422: Build Diff
Build 28421: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 25 2020, 23:16
deadalnix requested changes to this revision.Nov 25 2020, 23:34

1/ Let the linter do its job.
2/ npm i plain doesn't work.

web/cashtab/.editorconfig
20 ↗(On Diff #26044)

Prettier will deal with that. We also don't want to have project specific configs this way.

web/cashtab/.prettierrc
7 ↗(On Diff #26044)

Remove

web/cashtab/.vscode/launch.json
14 ↗(On Diff #26044)

We don't really support vscode, are you suing it yourself? If not then remove this.

This revision now requires changes to proceed.Nov 25 2020, 23:34

Switch from yarn to npm, remove unneeded config files, remove pre-commit cashtab linting

deadalnix requested changes to this revision.Nov 26 2020, 13:18
deadalnix added inline comments.
web/cashtab/package-lock.json
1 ↗(On Diff #26048)

I'm getting massive changes in there from npm install. npm update is busted.

This revision now requires changes to proceed.Nov 26 2020, 13:18

Specifying node and npm versions, updating readme, welcome msg revision from feedback

deadalnix requested changes to this revision.Nov 26 2020, 17:26

Please don't start a project on outdated tech.

web/cashtab/README.md
20

Why? This is what ship standard on most distros. Also, how is this going to work when we have several node projects in there and each require a specific version of node?

This revision now requires changes to proceed.Nov 26 2020, 17:26

Documentation for correct node 15 use, patch for obsolete test

deadalnix requested changes to this revision.Nov 26 2020, 19:17
deadalnix added inline comments.
web/cashtab/README.md
25 ↗(On Diff #26054)

Update the test plan accordingly.

web/cashtab/src/components/Configure/__tests__/Configure.test.js
29

Why was this test removed?

This revision now requires changes to proceed.Nov 26 2020, 19:17

Upgrading jest for proper error msg from test, patching test error

deadalnix requested changes to this revision.Nov 26 2020, 21:15

The test plan still cannot be executed as this.

This revision now requires changes to proceed.Nov 26 2020, 21:15

The test plan still cannot be executed as this.

What errors are you seeing?

I can run the testplan on my Arch box.

On a debian buster machine running our CI script it fails a test and complains about Npm being <6. I can run the test plan after apt-get -t buster-backports install npm for 6.14.8 only.

Specify required versions of nodejs and npm in CONTRIBUTING.md

deadalnix requested changes to this revision.Nov 29 2020, 17:02

I can run the testplan on my Arch box.

On a debian buster machine running our CI script it fails a test and complains about Npm being <6. I can run the test plan after apt-get -t buster-backports install npm for 6.14.8 only.

Shipping your arch box to every users do not seems like an appropriate alternative to fixing the test plan.

This revision now requires changes to proceed.Nov 29 2020, 17:02

It is working now that you updated jest. Go for it.

This revision is now accepted and ready to land.Nov 29 2020, 17:38
This revision was automatically updated to reflect the committed changes.