Differential D8720

[net/refactor] Remove m_manual_connection flag from CNode
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6a9f46ff27ed: [net/refactor] Remove m_manual_connection flag from CNode

Summary

Partial backport (10/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/49efac5cae7333c6700d9b737d09fae0f3f4d7fa

Depends on D8719.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p10

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14471
Build 28906: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28905: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 11:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:56

Fabien requested review of this revision.Dec 21 2020, 11:56

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:57

Fabien added a child revision: D8721: [net/refactor] Remove fFeeler flag from CNode.Dec 21 2020, 12:06

Harbormaster completed remote builds in B14471: Diff 26466.Dec 21 2020, 12:23

PiRK accepted this revision.Dec 21 2020, 13:27

This revision is now accepted and ready to land.Dec 21 2020, 13:27

Closed by commit rABC6a9f46ff27ed: [net/refactor] Remove m_manual_connection flag from CNode (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a9f46ff27ed: [net/refactor] Remove m_manual_connection flag from CNode.

Revision Contents
Changeset List

Path

Size

src/

net.h

3 lines

net.cpp

14 lines

net_processing.cpp

10 lines

Diff 26466

View Options

src/net.h

View Options

src/net.cpp

View Options

[net/refactor] Remove m_manual_connection flag from CNodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26466

src/net.h

src/net.cpp

src/net_processing.cpp

[net/refactor] Remove m_manual_connection flag from CNode
ClosedPublic
Actions

Revision Contents
Changeset List