[net/refactor] Remove fFeeler flag from CNode
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:06.

Details

Reviewers

PiRK
majcosta

Group Reviewers

Restricted Project

Commits

rABCf7d2a6ea27fb: [net/refactor] Remove fFeeler flag from CNode

Summary

Partial backport (11/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/14923422b08ac4b21b35c426bf0e1b9e7c97983b

Depends on D8720.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p11

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14472
Build 28908: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28907: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 12:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:06

Fabien requested review of this revision.Dec 21 2020, 12:06

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:06

Fabien added a child revision: D8722: [net/refactor] Remove m_addr_fetch member var from CNode.Dec 21 2020, 12:10

Harbormaster completed remote builds in B14472: Diff 26467.Dec 21 2020, 12:30

PiRK accepted this revision.Dec 21 2020, 13:35

This revision is now accepted and ready to land.Dec 21 2020, 13:35

majcosta accepted this revision.Dec 21 2020, 13:39

Closed by commit rABCf7d2a6ea27fb: [net/refactor] Remove fFeeler flag from CNode (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf7d2a6ea27fb: [net/refactor] Remove fFeeler flag from CNode.

Revision Contents
Changeset List

Path

Size

src/

net.h

4 lines

net.cpp

19 lines

net_processing.cpp

7 lines

test/

net_tests.cpp

3 lines

Diff 26467

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

[net/refactor] Remove fFeeler flag from CNodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26467

src/net.h

src/net.cpp

src/net_processing.cpp

src/test/net_tests.cpp

[net/refactor] Remove fFeeler flag from CNode
ClosedPublic
Actions

Revision Contents
Changeset List