Differential D8723

[net/refactor] Remove fInbound flag from CNode
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:14.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCae844b952fd7: [net/refactor] Remove fInbound flag from CNode

Summary

Partial backport (13/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/60156f5fc40d56bb532278f16ce632c5a8b8035e

Depends on D8722.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p13

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14474
Build 28912: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28911: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 12:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:14

Fabien requested review of this revision.Dec 21 2020, 12:14

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:14

Fabien added a child revision: D8724: [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections.Dec 21 2020, 12:18

Harbormaster completed remote builds in B14474: Diff 26469.Dec 21 2020, 12:41

majcosta accepted this revision.Dec 21 2020, 13:46

This revision is now accepted and ready to land.Dec 21 2020, 13:46

Closed by commit rABCae844b952fd7: [net/refactor] Remove fInbound flag from CNode (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCae844b952fd7: [net/refactor] Remove fInbound flag from CNode.

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

net.cpp

24 lines

net_processing.cpp

41 lines

test/

net_tests.cpp

4 lines

Diff 26469

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

[net/refactor] Remove fInbound flag from CNodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26469

src/net.h

src/net.cpp

src/net_processing.cpp

src/test/net_tests.cpp

[net/refactor] Remove fInbound flag from CNode
ClosedPublic
Actions

Revision Contents
Changeset List