Differential D8728

[refactor] Remove IsOutboundDisconnectionCandidate
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:58.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC91061791c00f: [refactor] Remove IsOutboundDisconnectionCandidate

Summary

Partial backport (18/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/bc5d65b3ca41eebb1738fdda4451d1466e77772e

Depends on D8727.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p18

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14480
Build 28924: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28923: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:58

Fabien requested review of this revision.Dec 21 2020, 12:58

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:58

Fabien added a child revision: D8729: [net] Remove unnecessary default args on CNode constructor.Dec 21 2020, 13:04

Harbormaster completed remote builds in B14480: Diff 26475.Dec 21 2020, 13:26

majcosta accepted this revision.Dec 21 2020, 14:03

This revision is now accepted and ready to land.Dec 21 2020, 14:03

Closed by commit rABC91061791c00f: [refactor] Remove IsOutboundDisconnectionCandidate (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 16:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC91061791c00f: [refactor] Remove IsOutboundDisconnectionCandidate.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

14 lines

Diff 26475

View Options

[refactor] Remove IsOutboundDisconnectionCandidateClosedPublicActions